tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
11,700 Commits 31 Branches 527 Tags 162 MiB
0c4ec4708b
Commit Graph

35 Commits

Author SHA1 Message Date
Ingo Schommer
0c4ec4708b API Using $HolderID for form field container templates 
Replaces duplicate $ID usage.
See https://github.com/silverstripe/silverstripe-framework/pull/1873
 2013-05-31 19:46:11 +02:00
Will Rossiter
ca87b8b794 API: Form Field ID attribute should follow HTML specification 
Fixes: http://open.silverstripe.org/ticket/4431.

Changes Form and Form Field classes to make use of Convert::raw2htmlid() which follows http://www.w3.org/TR/REC-html40/types.html#type-cdata.

Introduces a FormTemplateHelper class to assist in these sort of updates in the future.
 2013-05-26 11:11:55 +12:00
uniun
c48eca1615 The MAX_FILE_SIZE field must precede the file input field. 
More here: http://php.net/manual/en/features.file-upload.post-method.php
 2013-05-02 11:15:55 +03:00
Hamish Friedlander
7efae6b95f Merge remote-tracking branch 'origin/3.0' into 3.1 2013-02-18 14:31:57 +13:00
Ingo Schommer
f8bbc0a726 BUGFIX Escape HTML in DropdownField and ListboxField 
Fixes reflected XSS in Group titles when using
in group selections (e.g. in "New Member" form).
 2013-02-17 23:27:15 +01:00
Ingo Schommer
1ca3883a76 NEW Tooltip and inline help text support for CMS form fields 2012-12-14 01:58:04 +01:00
Ingo Schommer
6f9d01f621 API FormField->setDescription() visible in default template 
Renders into <span class="description"> instead of "title" attribute
 2012-12-14 01:58:04 +01:00
Ingo Schommer
bcbf4636fc BUG Remove .ss-tabset class from CMS tabs to prevent rogue ajax load (#7980) 
The existence of .ss-tabset triggers JS which applies $.tabs(),
and in turn interprets the first available link as the tab navigation.
jQuery UI subsequently tries to ajax-load this link, which is not
desired. Instead, $.tabs() should *only* be applied to a container
DOM element with .cms-tabset applied.
 2012-11-01 00:25:13 +01:00
Damian Mooyman
06676175ed FIXED: Issue where messages attached to checkbox fields would not be displayed. 2012-09-03 18:21:11 +12:00
Ingo Schommer
2e21574988 NEW FieldGroup_DefaultFieldHolder template 
As a replacement for the FieldGroup->subfieldParam
setting available in 2.4. Usage through FieldGroup->setTemplate().
 2012-08-27 15:41:56 +02:00
Ingo Schommer
ce2d31b060 BUG Consistently self-closing form field tags (#7557) 
This is reverting templates back to pre-3.0 conventions,
which were dominated by XHTML templates.
HTML5 allows both self-closing and unclosed tags,
so opting for self-closing to achieve maximum compatibility.
 2012-08-10 10:27:33 +02:00
Ingo Schommer
6c1f7997a4 ENHANCEMENT HTML titles in TreeDropdownField 
HTML in tree nodes is already used to render page icons via SiteTree->TreeTitle.
In order to select the initial value correctly via HTML5 data attributes,
we need to encode any HTML values.
 2012-06-13 16:04:14 +02:00
Andrew Short
9e4b526213 MINOR: Include the title attribute on tree and readonly fields. 2012-06-13 13:19:16 +02:00
Andrew Short
aa67b56b10 ENHANCEMENT: Refactored ToggleCompositeField. 
* Use jquery ui accordion for the field, and implemented an admin theme.
* Made the setting of configuration consistent with other form fields.
* ToggleComposteField->startClosed() has been deprecated in favour of
  setStartClosed().
* Removed public access to the heading level, instead use getHeadingLevel()
  or setHeadingLevel().
 2012-06-13 14:20:27 +10:00
Andrew Short
8976c82a35 MINOR: Fixed nested tab styling. 
* Added and styled border below nested tabs.
* Fixed duplicate nested tabset divs being created.
 2012-06-13 00:43:04 +10:00
Naomi Guyer
458171ff92 ENHANCEMENT: Gridfield usability (fixes 7215) 
1. Modified gridfield to use default colours
2. Added ability to show and hide the filter
3. Design changes to icons used
4. Gridfield template fixes: Took out broken mark-up from templates
(spans were being inserted inside spans), and adjusted styles. Added
extra class to template
5. Added "filter by ..." placeholder text to input fields
 2012-05-16 12:18:23 +12:00
Andrew Short
9e6273ce9a MINOR: Fixed deprecated method usage in ToggleCompositeField. 2012-05-12 18:48:44 +10:00
Sean Harvey
6f672e5f36 MINOR Fixing use of <% control %> with <% with %> or <% loop %> as necessary. 2012-05-11 13:49:20 +12:00
Ingo Schommer
6d999aa6ba ENHANCEMENT addExtraClass() support for Tab and TabSet 2012-05-08 11:25:44 +02:00
Normann Lou
3b3b515571 API CHANGE Read-only fields no longer include companion hidden fields (see pull request #399) 
BUGFIX Remove legacy code and template which is never picked-up so that TextareaField becomes 'readonly' when it is transfered to readonly field. Change TextareaFieldTest test cases to address a 'readonly' textarea field displaying the special html characters correctly.
 2012-05-03 14:24:03 +02:00
Ingo Schommer
7fdfd4d52e BUGFIX Changing CheckboxField_holder_small template order back to 2.4 ordering: Show checkbox before label 2012-05-02 14:04:44 +02:00
Ingo Schommer
ed5110dbbf MINOR Self-closing input tab in HIddenField to keep broadest markup compliance by default 2012-04-18 18:23:23 +02:00
Sean Harvey
8949dfa691 ENHANCEMENT Replaced locations of sapphire with $ModulePath(framework) in templates, based off Controller which implements TemplateGlobalProvider 2012-04-15 10:50:20 +12:00
Simon Welsh
3a6341a251 API-CHANGE sapphire folder can now be renamed. 2012-04-15 10:50:19 +12:00
Will Rossiter
7df26fd702 BUGFIX: fix missing TabSet template from previous changes and selection group using wrong holder. 2012-04-14 22:08:00 +12:00
Will Rossiter
07d2d5273a ENHANCEMENT: populate FormField:: on the fly based on class name of field rather than requiring explict definition. 2012-04-14 17:36:19 +12:00
Will Rossiter
907568b182 ENHANCEMENT: move hard coded template HTML for composite field and field group out to separate template files. 2012-04-14 17:36:08 +12:00
Ingo Schommer
55a0fb18e4 API CHANGE Deprecated FormField->describe(), use setDescription() instead. Actually use the description in form fields other than FormAction. 2012-03-07 13:32:42 +01:00
Ingo Schommer
5d565dcfa3 ENHANCEMENT Added ListboxField->setDisabledItems() and setDefaultItems() (similar to CheckboxSetField API) 2012-03-05 16:11:29 +01:00
Ingo Schommer
46628721fe ENHANCEMENT Using chosen.js for group selection in Member->getCMSFields() 2012-03-02 20:46:22 +01:00
Ingo Schommer
454b89f2bb BUGFIX Fixed FormAction.ss template when used with <button> tag 2012-02-17 13:35:54 +01:00
Ingo Schommer
b5421d9598 ENHANCEMENT Allowing custom attributes in (most) FormField implementations, which allows for HTML5 data attributes 2012-01-02 16:48:14 +01:00
Ingo Schommer
475f3764c3 BUGFIX Using separate template for readonly version of Textarea (mainly to avoid SSViewer bugs, but also for more granular customisation) 2012-01-02 16:48:14 +01:00
Sean Harvey
19e9b19a1a BUGFIX Ensure TextareaField template is encoding characters correctly 2012-01-02 16:48:13 +01:00
Sean Harvey
9e548f501e API CHANGE FormField::Field() and FormField::FieldHolder() now render into templates on each FormField instead of creating HTML from PHP 2012-01-02 16:48:13 +01:00