Commit Graph

36 Commits

Author SHA1 Message Date
Simon Welsh
d795b191ec Add codesniffer that ensures indentation is with tabs. 2012-12-12 17:39:34 +13:00
Simon Welsh
379b561cdb BUG RSSFeed now sets the Content-Type on the current HTTPResponse
RSSFeed::outputToBrowser() used to use header() directly to set the content-type.
This stopped ContentNegotiator from correctly detecting that it didn't need to
convert the response, invalidating the XML.
2012-12-12 10:38:56 +13:00
Sam Minnee
1f7fc1f76a FIX Remove instances of lines longer than 120c
The entire framework repo (with the exception of system-generated files) has been amended to respect the 120c line-length limit.  This is in preparation for the enforcement of this rule with PHP_CodeSniffer.
2012-09-30 17:18:13 +13:00
Ingo Schommer
e2f073f38a Method visibility according to coding conventions 2012-09-20 10:46:59 +02:00
Will Rossiter
7558d32da6 FIX: use standard template rendering process for RSS feeds
This changes the behaviour of output to browser to use the standard SilverStripe rendering process rather than an echo statement to enable easier testability.
2012-07-31 20:38:41 +12:00
Mateusz Uzdowski
34fdad8d50 Minor typo in RSS feed. 2012-07-20 09:08:40 +12:00
Will Rossiter
f1db65d6b6 API: add api for setting a custom template on a RSS feed.
See initial idea at http://open.silverstripe.org/ticket/6441. Added $template property and corresponding getters / setters for customizing the template used. Added relevant unit test.
2012-07-01 21:27:50 +12:00
Simon Welsh
f07258f3cf MINOR Update @package values to match renaming sapphire 2012-04-15 10:50:19 +12:00
Fred Condo
d370423825 Clean up trailing ?> per coding standard
All sapphire but the lang directory
2012-02-12 12:40:16 -08:00
Stig Lindqvist
e38dd08ea5 MINOR: Fix docblocks to reference SS_List instead of (now deprecated) DataObjectSet where appropriate 2011-10-28 15:58:55 +13:00
Will Rossiter
1732a17114 Merged new-orm into datagrid 2011-09-26 16:47:54 +13:00
Ingo Schommer
ce8e72cf0e MINOR Removing executable flag from all files (thanks miiihi) 2011-09-18 22:04:02 +02:00
ajshort
3f132a105b API CHANGE: Replaced DataObjectSet instances with ArrayList. 2011-05-05 20:40:24 +10:00
ajshort
04e5dae22e MINOR: Updated places that expect a DataObjectSet to accept an SS_List instance. 2011-05-02 17:14:05 +10:00
Sam Minnee
be40e11c72 BUGFIX #6096 RSSFeed::feedContent() restores previous state of SSViewer::get_source_file_comments() after temporarily disabling it (thanks paradigmincarnate!) (from r111914)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112944 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:06:53 +00:00
Sam Minnee
cc355a4f18 API CHANGE: Replaced eval based creation of extension and field objects with Object::create_from_string().
API CHANGE: Introduced new function Object::create_from_string() to instantiate an object from a string like 'Int(50)' (from r101093)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111585 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:46:41 +00:00
Ingo Schommer
252be427f7 ENHANCEMENT #5072 RSSFeed_Entry::rssField() now respects custom getters on the data class (from r100400)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105559 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:49:55 +00:00
Andrew Short
f29eceecff API CHANGE #3724: Unified the Link() method to accept an action parameter.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88495 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-11 00:07:16 +00:00
Sean Harvey
b77d088d47 Merged in parent::__construct() additions from branches/2.3 - r83580 and r83587
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86676 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-18 03:02:19 +00:00
Andrew O'Neil
60f75c5ca4 Merged changes from 2.3 branch
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@71172 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-01 23:49:53 +00:00
Sam Minnee
74fd64b6d0 BUGFIX #2963 - Fix RSSFeed to work with new add_cache_headers
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64361 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 04:33:02 +00:00
Ingo Schommer
60860cc1b9 MINOR Unified @package PHPdoc (added where missing, removed duplicates)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@56212 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-06-15 13:33:53 +00:00
Sam Minnee
a6af17943c Merged revisions 52295 via svnmerge from
http://svn.silverstripe.com/open/modules/sapphire/branches/2.2.2

........
  r52295 | aoneil | 2008-04-08 12:25:24 +1200 (Tue, 08 Apr 2008) | 2 lines
  
  fix links in RSS feeds
........


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@53510 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-04-26 06:47:56 +00:00
Sam Minnee
7eea3c091f Added tests for RSSFeed
Don't require  information on objects passed to RSSFeed

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@51523 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-03-21 05:58:50 +00:00
Sam Minnee
d500a32098 Merged revisions 50921 via svnmerge from
http://svn.silverstripe.com/open/modules/sapphire/branches/2.2.2

........
  r50921 | sminnee | 2008-03-12 12:49:44 +1300 (Wed, 12 Mar 2008) | 1 line
  
  Make RSS feed work with objects that don't support AbsoluteLink, such as the forum
........


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@51204 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-03-17 08:24:08 +00:00
Sam Minnee
59d8a1ce8e Improving API documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@50453 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-03-02 23:24:10 +00:00
Matt Peel
7d13ba7fb8 Reverted geoffm's accidental commit to /open
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@50107 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-02-25 02:10:37 +00:00
Geoff Munn
bf3c09bec6 First post
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@50105 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-02-25 01:06:39 +00:00
Sam Minnee
7917df81ed #1956 - Show Title in RSSFeed
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@49177 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-02-07 03:08:30 +00:00
Sam Minnee
b1d2e3906b API Documentation updates
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@47766 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-01-09 04:18:36 +00:00
Sam Minnee
d27937f448 Updated API documentation package tags
Fixed some whitespace

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@47725 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-01-08 06:37:50 +00:00
Matt Peel
15837d7775 Tidied up file endings and spaces between methods
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43894 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-26 05:51:47 +00:00
Matt Peel
07b0d18fa7 Trac #1556: Added if() check around a foreach loop that was causing errors when there were no entries in an RSS feed.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43890 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-26 05:28:05 +00:00
Ingo Schommer
0578d3f46a Avoid double-escaping in class AND template for title/description
see http://trac/silverstripe/changeset/40552 for an invalid fix that wasn't merged


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42106 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 16:00:07 +00:00
Ingo Schommer
98486e0450 mlanthaler: Added support for conditional GETs for RSS feeds (added support for ETag an Last-Modified headers).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42105 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 15:56:15 +00:00
Hayden Smith
4a5d9b03f8 Moved Sapphire module to open source path
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@39001 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-07-19 10:40:28 +00:00