tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
2,196 Commits 31 Branches 527 Tags 162 MiB
0ad968090a
Commit Graph

2196 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ingo Schommer
916df369d8 BUGFIX Consistenly returning cloned instances for all FormField classes when calling performReadonlyTransformation() or performDisabledTransformation(). Making sure that these instances are actually flagged as readyonly/disabled. Addd unit tests to dynamically instanciate most FormField classes to check for this behaviour. Originally, this bugfix was necessary to avoid changed FormField state when recursively calling replaceField() on FieldSet->dataFields() in Translatable->updateCMSFields() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66505 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Sean Harvey
3431e9815b BUGFIX Removed hacky code setting fields in the SearchForm constructor 
BUGFIX Removed SearchForm->FormMethod() and used $this->setFormMethod() in SearchForm constructor instead which is a nicer solution instead of overloading a Form method

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66431 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Will Rossiter
07e9aaa547 MINOR: added setter function to write_js_on_body() so I can override the settings 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66426 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Normann Lou
92e7071412 APICHANG: if a DataObject has getCMSActions, its model admin should be able to add them. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66392 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Sam Minnee
9d1be81b41 Merge pre-2.3-oct08 into 2.3 (via trunk) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66353 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Sam Minnee
2606f99fb4 ENHANCEMENT: Added comments in rendered templates to indicate the source .ss files, on dev sites only: 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66343 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Ingo Schommer
77575e69b7 BUGFIX Hiding "change password" fields by default in admin/myprofile, they shouldn't validate the input by default. Replaced with a link to toggle those fields (#3106) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66334 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Ingo Schommer
4cc3ace3b8 ENHANCEMENT Added ConfirmedPasswordField->setShowOnClickTitle() 
MINOR Documentation for ConfirmedPasswordField

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66333 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Ingo Schommer
03277b5349 BUGFIX Include jquery_improvements.js whenever jquery.js is required, so jQuery.noConflict() is set. This is required to ensure $() behaves in the prototypey way (alias for document.getElementByID()) rather than jQuery style (document.getElementsBySelector()) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66332 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Ingo Schommer
e772a4c1d4 ENHANCEMENT Respecting SiteTree->canView() settings in results (see #3052). This causes wrong counts, bugreport in #3120 
ENHANCEMENT Added $data parameter to SearchForm->getResults() to remove dependency on $_REQUEST for better testability
ENHANCEMENT Added SearchForm->numPerPage - this shouldn't need to be passed around methods on every call, its instance specific
ENHANCEMENT Added SearchFormTest
MINOR Documentation for SearchForm


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66322 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Sean Harvey
5e3726ff43 ENHANCEMENT Added more known file extensions (tiff, js, html, css, ico) to File->getFileType() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66320 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Sean Harvey
55dbe2bf52 BUGFIX Check if $member variable isn't empty before looking for first name in MemberLoginForm 
MINOR Coding conventions, inconsistent use of tabs and spaces

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66318 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Sean Harvey
e50b7369b7 BUGFIX Fixed call to incorrect case of function name, Member::currentUser() should be used 
MINOR Code conventions (spaces should be between operator characters)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66317 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Ingo Schommer
a9bc9c6845 BUGFIX Fixed ForeignKey->scaffoldFormField() usage of model class instead of relation class to generate dropdown list 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66313 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Ingo Schommer
3a220c9e38 ENHANCEMENT Added support for $relationCallbacks on the importer class (in addition to methods on the model class) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66312 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Sean Harvey
76f15e47bf MINOR Removed old references from workflow in SiteTree and VirtualPage (AssignedToID and RequestedByID were old properites of a workflow page type) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66311 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Sean Harvey
29899c4396 BUGFIX Fixed HasManyComplexTableField, and subclass fields HasOneComplexTableField and ManyManyComplexTableField saving bug because javascript wasn't being included properly 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66306 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Sam Minnee
f15cfaccf4 BUGFIX: Fixed recursion bug with FieldSet::fieldPosition 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66305 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Sam Minnee
10c6c394b8 Fixed bug in test makefile 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66304 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Ingo Schommer
647c25ca14 MINOR Added isset($_SERVER['HTTP_HOST']) checks to Director->isDev() and Director->isTest() - these environment variables are not available in CLI mode, and show up as PHP notices in a default cli-script/sake execution 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66302 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Sam Minnee
e4bcce061c Build database before testing, for RestfulService test, etc 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66296 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sean Harvey
c20e69d563 MINOR Code formatting in FormField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66270 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sam Minnee
b40dbbb2f0 BUGFIX: Merged from trunk; fix DataObject::hasDatabaseFields() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66269 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sam Minnee
0eac163b11 API CHANGE: Deprecated Controller::PastVisitor(), it generates a lot of unused cookies 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66268 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sam Minnee
03c88ba020 Return an HTTPResponse consistently from controllers 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66267 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sam Minnee
6d5db643ab API CHANGE: Improve encapsulation of cookies in Director::test() 
BUGFIX: Fix test/cookie conflict in ErrorPage rendering

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66266 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sam Minnee
4f84e92dbf Fixed RequirementsTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66265 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sam Minnee
adb03a1d88 BUGFIX: Removed unnecessary and bug-causing Behaviour.apply() call. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66251 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Andrew O'Neil
d76611f380 #2771: Fix SQLQuery::filtersOnID() (wakeless) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66225 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Andrew O'Neil
4c81b8c3a5 BUGFIX #2714 - Cookie::set doesn't operate correctly with expiryDays 0 (wakeless) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66196 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Andrew O'Neil
e3298047c3 #2635 - More informative errors in DataObject (simon_w) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66192 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Ingo Schommer
66f2cb4d63 API CHANGE Moving GoogleSitemap functionality into new "googlesitemaps" module 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66175 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Ingo Schommer
c6bf307b94 ENHANCEMENT Moving GoogleSitemap functionality (priority dropdown and database fields) from SiteTree to GoogleSitemapDecorator 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66173 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Ingo Schommer
2153737da7 ENHANCEMENT Added SiteTreeDecorator 
ENHANCEMENT Addings hooks in SiteTree for onBeforeUnpublish and onAfterUnpublish
ENHANCEMENT Removed GoogleSitemap references in SiteTree (moving to decorator implementation)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66168 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Ingo Schommer
1cdca8a66a BUGFIX Fixed editable formfields not showing up in translation mode (#3083). Updated Translatable->updateCMSFields() by partially merging wakeless' patch from (r64523) 
ENHANCEMENT Added Translatable_Transformation (patched in r64523)
ENHANCEMENT Added TranslatableTest with minimal assertions about existing form fields in translation mode

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66137 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Ingo Schommer
db0815c115 BUGFIX Fixed PHP variable initialization in SiteTree->getClassDropdown() which broke class dropdown in behaviour tab (regression from r66092) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66107 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Geoff Munn
a14afe10d4 FIX: permission migrator for missing groups 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66103 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Ingo Schommer
63866493e7 MINOR Removed debug code in AjaxUniqueTextField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66093 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Ingo Schommer
e99ca1092f MINOR Fixed PHP Notice in SiteTree 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66092 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Ingo Schommer
df9472631e BUGFIX $cache flag wasn't passend through from ViewableData_Customised->XML_val() to ViewableData->XML_val() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66091 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Will Rossiter
a92d2120a1 Merged pre-2.3-oct08 into branches/2.3 (via trunk) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66084 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Sean Harvey
c7307eefad BUGFIX Fixed HTTP->findByTagAndAttribute missing variable error causing HtmlEditorField to break since it used HTTP::getLinksIn() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66070 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Sam Minnee
dec3c44259 BUGFIX: Fixed security tabs for JSoD code 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66065 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Sam Minnee
abd6f11d44 BUGFIX #3087 simon_w: Added ResfulService::connect() back, for backward compatability 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66052 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Ingo Schommer
c5773e2f36 BUGFIX Fixed unescaped html display in DevelopmentAdmin (#3080) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66049 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Ingo Schommer
f4d0fec83b ENHANCEMENT Added support for custom importer methods in CsvBulkLoader 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66045 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Sean Harvey
5df7e70cf8 BUGFIX Fix PHP notice where variable with array didn't exist in HTTP->findByTagAndAttribute() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66043 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Normann Lou
3f154aaca1 BUGFIX: use a undefined variable $member. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66029 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sean Harvey
b9115b8088 BUGFIX Fixed incorrect call to Permission::checkMember() - missing second argument, first argument should've been a Member object or Member ID 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66027 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sean Harvey
3c7a72e22a BUGFIX Fixed PHP notice level error in some circumstances in DataObject->buildDataObjectSet() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66026 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00