Simon Welsh
1d5706f15c
Correct line length and indentation
2014-03-30 21:11:56 +13:00
Simon Welsh
7ee70cec0b
Merge pull request #2778 from grooverdan/patch-1
...
Update install.php5 - error handling on getDatabaseConfigurationHelper
2014-03-15 21:17:30 +13:00
Simon Welsh
dbb6ba82f8
Handle special characters in error messages when html_errors is Off
...
Fixes #1538
2014-03-15 14:38:54 +13:00
Damian Mooyman
0cbad41d3b
Rewrote usages of error suppression operator
2014-03-05 15:48:55 +13:00
Simon Welsh
ccb791995e
Merge pull request #2894 from wilr/3.1-manymanyyaml
...
Add support for many_many_extraField in YAML
2014-03-04 11:35:58 +13:00
Will Rossiter
8b92300622
Add support for many_many_extraField in YAML
...
Format is
RelationName:
- =>Obj.name:
ExtraFieldName: "Foo"
2014-02-24 22:03:53 +13:00
Ingo Schommer
8ab0fd879d
Merge pull request #2892 from silverstripe/log_formatter_defaults
...
Adding defaults for unhandled event priorities in log formatters.
2014-02-24 21:48:10 +13:00
Sean Harvey
af01d7f024
Adding defaults for unhandled event priorities in log formatters.
...
Unhandled types wouldn't show up in the error format message, and a
notice "undefined $errtype" is displayed on these cases.
2014-02-24 15:41:03 +13:00
Thomas Speak
437cbe0d91
DOC: SapphireTest objFromFixture
...
The current docs for `objFromFixture` cause PHPStorm to generate an error because of the mismatched data types.
`$product = $this->objFromFixture('ProductPage', 'StandardSpecs');`
Causes: `Expected The, got string`.
2014-02-21 10:21:18 +00:00
Ingo Schommer
caaf286767
Merge pull request #2821 from silverstripe-rebelalliance/rfc4180
...
BUG: Fixed out of date RFC 4180 URL
2014-02-07 17:51:03 +13:00
Ingo Schommer
db07a8e1df
Fix $disable_themes test state
...
Wasn't resetting the value after using it
2014-02-07 16:38:41 +13:00
Kirk Mayo
4b2352afcf
NEW: Correcting the JSRunnerTest template comments
2014-02-07 10:40:28 +13:00
Kirk Mayo
e2c312d87d
BUG: Fixed out of date RFC 4180 URL
...
BUG: Fixed out of date RFC 4180 URL
2014-02-05 14:44:56 +13:00
Joel Marcey
0da5413e8d
Support PHPUnit 3.8+ compatibility
...
Summary:
PHPUnit 3.8+ adds a method to its PHPUnit_Framework_TestListener called addRiskyTest(). Need to stub it out to avoid "must implement this interface method" fatals when using 3.8+
Test Plan:
Reviewers:
CC:
Task ID: #
Blame Rev:
2014-02-03 15:32:58 -08:00
Ingo Schommer
ab070944d5
Merge branch 'pulls/apidocs-package-list' of https://github.com/madmatt/silverstripe-framework into madmatt-pulls/apidocs-package-list
...
Conflicts:
view/SSTemplateParser.php
view/SSTemplateParser.php.inc
2014-01-31 15:15:59 +13:00
Daniel Black
fb12d1ee37
Update install.php5
...
Defaulting to MySQL here is really dumb. There is an explicit type as an argument so falling back to mysql could result in "I couldn't write to path ....db" despite the real error that the include of the sqlite3/code/SQLiteDatabaseConfigurationHelper.php failed for some reason.
Other uses of getDatabaseConfigurationHelper also need a similar error handler.
2014-01-14 13:07:09 +11:00
madmatt
bebe0f6e37
Updating @package and @subpackage doc tags
2013-11-29 17:49:30 +13:00
Sean Harvey
be99d1532b
Merge pull request #2674 from chillu/pulls/friendlyerror-contenttype
...
FIX text/html type for Debug::friendlyError() in live mode
2013-11-18 12:09:59 -08:00
Ingo Schommer
a0dbfc61b6
FIX text/html type for Debug::friendlyError() in live mode
...
Avoid unparsed HTML responses in case of httpError(4xx) or
httpError(5xx) in live mode. The SS_HTTPResponse_Exception constructor
automatically set "text/plain" a content type, which conflicts
with the later choice of Debug::friendlyError() to return HTML.
This is a hotfix, needs more work to properly separate
logic flow from presentation concerns (e.g. through request processors).
2013-11-18 16:02:12 +01:00
websTTer
cd3cc1b923
Fix installer isIIS() to include IIS versions greater than 7.
2013-11-18 14:34:32 +13:00
Damian Mooyman
640d5beb44
BUG fix missing permission for dev/build/defaults
2013-11-08 11:09:46 +13:00
Ingo Schommer
91f6039eed
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
control/Director.php
2013-11-05 10:15:40 +01:00
Ingo Schommer
65b4407337
FIX "Draft" stage to fix dev/build, Versioned docs ( fixes #2619 )
2013-11-03 21:27:26 +01:00
Sean Harvey
fd2e7c1dd3
Use getTempFolder() from core when checking for temp in installer.
...
Fix for issue #2420 . Instead of using custom temp folder discovery
code in the installer, use the core getTempFolder() instead.
2013-11-01 13:53:53 +13:00
Sean Harvey
d8f29fcc04
Merge pull request #2236 from chillu/pulls/isdev-infinite-loop
...
FIX Avoid infinite loops on ?isDev=1 and Deprecation class
2013-10-31 15:59:31 -07:00
colymba
4131f574fd
BUG backtrace now filters MySQLi arguments
...
Add MySQLi functions mysqli() and select_db() to the list of filtered
function arguments to avoid exposing sensitive data
2013-10-30 12:36:07 +02:00
Ingo Schommer
55729dfc27
Removed deprecated log/email logic from Debug ( fixes #2573 )
...
Was deprecated in 2009 with a682ab9c0e
,
and removed in 2012 with 9eca2d676f
2013-10-23 11:22:34 +02:00
Stephen Shkardoon
d2360ec8aa
MINOR typo where display_errors wasn't checked properly
2013-10-23 22:00:05 +13:00
Stephen Shkardoon
696e6f65ab
MINOR typo where display_errors wasn't checked properly
2013-10-23 16:32:31 +13:00
Damian Mooyman
371ccca350
BUG Less misuse of error control operator (@)
...
This is necessary to prevent get_last_error() from returning suppressed errors when retrieving values from nested arrays
2013-10-18 14:30:51 +13:00
zauberfisch
48049647d8
formatted install.php5 according to SilverStripe coding conventions (spaces)
2013-10-16 21:17:22 +01:00
zauberfisch
0b4c3946ff
formatted install.php5 according to SilverStripe coding conventions (tabs instead of spaces, no 1 line if with else, ...)
2013-10-16 21:11:06 +01:00
zauberfisch
c4810b8e0f
changed install.php5 to respect line length limit according to SilverStripe coding conventions
2013-10-16 21:00:20 +01:00
zauberfisch
e357fa298e
suggest that arg_separator.output to be &, if set to something else it may result in issues with url parameters
2013-10-16 20:37:15 +01:00
Ingo Schommer
5235a3f3a2
Installer regression from dd49834
2013-10-16 11:29:44 +02:00
Ingo Schommer
c05b7c2c8f
Installer regression from dd49834
2013-10-16 11:28:33 +02:00
Daniel Hensby
a8c9fffed4
Appending to debug.log file
...
Until now debug.log files were loaded into memory, concatenated and then re-written to disk. This is an intensive operation on a large file.
I've added the `FILE_APPEND` flag to append to this file instead.
2013-10-10 11:07:58 +01:00
Ingo Schommer
795d3e4b3b
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
dev/install/install.php5
docs/en/index.md
tests/core/CoreTest.php
2013-10-07 16:18:20 +02:00
Sean Harvey
dd49834b9e
BUG Fixing installer not checking display_errors correctly.
...
Fixes issue #2479 . Installer sets display_errors on, but it checks
the changed value and not the original one set in php.ini.
2013-10-04 10:05:28 +13:00
Ingo Schommer
4a3a88710f
Merge remote-tracking branch 'origin/3.1.0' into 3.1
...
Conflicts:
dev/BehatFixtureFactory.php
model/Hierarchy.php
tests/behat/features/bootstrap/FeatureContext.php
tests/core/CoreTest.php
2013-08-22 13:00:25 +02:00
Ingo Schommer
40c239076b
Merge remote-tracking branch 'origin/3.0' into 3.1.0
...
Conflicts:
model/Hierarchy.php
2013-08-22 12:55:47 +02:00
Simon Welsh
c66cc952d2
Correct line length and indentation
2013-08-21 21:27:16 +12:00
Simon Welsh
151baeede1
Correct line length and indentation
2013-08-21 18:54:05 +12:00
Ingo Schommer
afe06661ef
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
admin/templates/Includes/LeftAndMain_Menu.ss
admin/templates/Includes/ModelAdmin_ImportSpec.ss
admin/templates/Includes/ModelAdmin_Tools.ss
admin/templates/LeftAndMain.ss
admin/templates/ModelSidebar.ss
i18n/i18n.php
templates/ComplexTableField.ss
templates/ComplexTableField_popup.ss
templates/FileIFrameField_iframe.ss
templates/Includes/GridFieldItemEditView.ss
templates/Includes/TableListField_PageControls.ss
templates/RelationComplexTableField.ss
templates/TableField.ss
templates/TableListField.ss
2013-08-07 17:14:47 +02:00
Ingo Schommer
c0f5007d57
Create folder if required in dev/generatesecuretoken
2013-08-07 16:59:18 +02:00
Ingo Schommer
b159284c6c
Fixed "session started" error on install.php
2013-08-07 16:28:54 +02:00
Hamish Friedlander
2110493466
Merge branch '3.0' into 3.1
2013-08-07 09:43:52 +12:00
Hamish Friedlander
a685a8dee9
FIX Include flushtoken when install redirects to successfullyinstalled
2013-08-02 11:00:26 +12:00
Ingo Schommer
9d764d6794
FIX Avoid infinite loops on ?isDev=1 and Deprecation class
...
If any of the functionality triggered by Director::isDev()
was causing deprecation errors, the system would go into
an infinite loop. Since the only way to cause this is the DB
checking functionality, we disable that for Deprecation.
Side effect of this change: You can't show deprecation notices
on a live site by forcing the session into dev mode.
2013-07-17 11:55:19 +02:00
Ingo Schommer
bdbd61cb22
Merge remote-tracking branch 'origin/3.0' into 3.1
2013-07-11 15:14:07 +02:00