Commit Graph

1859 Commits

Author SHA1 Message Date
Sam Minnee
391848f79b FEATURE #2951 simon_w: Use 301 redirect on Director::forceWWW()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64231 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 21:06:15 +00:00
Ingo Schommer
be0d3e37c5 ENHANCEMENT Added Controller->redirectBack()
BUGFIX Storing HTTP "Referer" header from $_SERVER in Director::direct() and passing it along in Director::test()
ENHANCEMENT Storing a "fake referer" in TestSession->lastURL to allow for redirectBack() calls, e.g. after failed form validation

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64229 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 19:59:01 +00:00
Ingo Schommer
155fb9c10f BUGFIX Checking for an empty array for $postVars in Director::test() to determine HTTP method - an existing array should cause POST rather than GET, even if its empty
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64228 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 19:55:55 +00:00
Ingo Schommer
0fac0752a4 BUGFIX Fixed stupid ommission from r64223 which caused HTTPRequest to construct without a proper URL
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64227 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 19:53:59 +00:00
Ingo Schommer
524d7a9011 ENHANCEMENT Disrecard $includeRelations setting when scaffolding $has_one relationships in FormScaffolder - use $restrictFields to limit instead
BUGFIX Using fieldLabel() for $has_one relationships in FormScaffolder

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64224 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 19:31:18 +00:00
Ingo Schommer
90f3b87f35 ENHANCEMENT Making URL accessible through HTTPRequest->getURL()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64223 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 18:47:38 +00:00
Ingo Schommer
dcd77d065c BUGFIX Fixed wrong call to scaffoldCMSFields() in Member->getCMSFields(), removed addScaffoldRelationFields() call as this is done by the newly called parent::getCMSFields() already
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64173 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 00:29:16 +00:00
Ingo Schommer
a24ccecb69 FEATURE Added ForeignKey and used it in relation- and databasefield getters in DataObject
FEATURE Added FormScaffolder for more flexible scaffolding of FieldSets from DataObject metadata
API CHANGE Removed DataObject->addScaffoldRelationFields(), now in separate class FormScaffolder
API CHANGE Changed parameters for DataObject->scaffoldSearchFields() to unify them with scaffoldFormFields()
API CHANGE Added optional $params parameter to DataObject->getCMSFields() to be passed on to scaffoldFormFields()
API CHANGE Renamed DataObject->getFormFields() to getFrontEndFields()
ENHANCEMENT Added $params parameter to all DBField->scaffoldFormField() subclasses
API CHANGE Added third optional parameter $object to DBField::create() to comply with ForeignKey and PrimaryKey constructors

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64157 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-13 22:20:41 +00:00
Sam Minnee
57a84d5408 BUGFIX #2906 - Fixed manifest conflict in web-tests
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64153 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-13 21:34:38 +00:00
Sam Minnee
96e2c82075 Removed #! entry from cli-script.php; its unreliable and cli-script.php should be called as 'php cli-script.php' instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64152 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-13 21:25:30 +00:00
Ingo Schommer
e818f89962 ENHANCEMENT Setting default level for ContentController->getMenu($level = 1) to allow for calls without arguments
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64144 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-13 20:08:59 +00:00
Ingo Schommer
96a448a4b2 BUGFIX fixed ss.i18n.sprintf() call in Validator.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64142 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-13 12:26:39 +00:00
Sam Minnee
6fa55568ee BUGFIX #2936: Define STDOUT if it's not already defined...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64124 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-13 01:40:42 +00:00
Hayden Smith
8a1ab89b84 BUGFIX: Fixed order of arguments.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64109 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-12 22:21:35 +00:00
Andrew O'Neil
c26ccdffa0 FEATURE: #2601 - More template handlers
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64103 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-12 21:27:52 +00:00
Ingo Schommer
c11a9949a4 BUGFIX Bad XHTML in en_US language file (#2624) - thanks tiwoc!
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64099 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-12 16:25:29 +00:00
Ingo Schommer
97fed5ae57 BUGFIX Director::fileExists() fails on windows with absolute paths (#2935) - thanks to ajshort!
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64098 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-12 16:16:25 +00:00
Ingo Schommer
7f40b2b953 BUGFIX Fixed CSSContentParser to only use tidy on CLI mode if its available, and first check for existence of PHP tidy extension. Fixes failing unit tests on standard WAMP windows installations.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64097 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-12 16:15:24 +00:00
Ingo Schommer
c6f1a231a3 BUGFIX Fixed CSVParser assumptions about absolute unix-style filepaths - using Director::absFile() instead now
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64096 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-12 15:53:25 +00:00
Ingo Schommer
ab8c7fbedc BUGFIX Consistent usage of ss.i18n.sprintf() instead of ss.i18n.printf() - the method is returning a string rather than outputting directly, so should be sprintf()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64081 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 21:06:59 +00:00
Ingo Schommer
ec591fc1fe MINOR Documentation in i18n class
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64079 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 17:36:31 +00:00
Ingo Schommer
a9abe0e6ca ENHANCEMENT Using $locale in _t() instead of repeatedly calling i18n::get_locale()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64078 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 17:36:13 +00:00
Ingo Schommer
72047aa3a1 BUGFIX Fixing AssetAdmin translations which were previously moved to Folder.php - i18n::include_by_class() doesn't like filenames/namespaces which are in a different folder than the language file they're referenced in (see #2359) - started in r64076
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64077 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 17:35:24 +00:00
Ingo Schommer
17ba4ded80 ENHANCEMENT Replaced hardcoded "en_US" references in i18n class with $default_locale
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64075 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 16:13:56 +00:00
Ingo Schommer
b562fcc934 BUGFIX Fixed AssetTableField javascript errors caused by r64049
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64074 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 16:07:01 +00:00
Ingo Schommer
8cc5625708 ENHANCEMENT Ability to add title constructor arguments to Tab and TabSet classes to resolve i18n issues with untranslated or unreferencable Tabs (see #2359)
ENHANCEMENT Support for $field_labels in relation tabs created by DataObject->addScaffoldRelationFields()
ENHANCEMENT Type checking and user errors for Tab and TabSet constructor arguments
ENHANCEMENT Supporting titles in FieldSet->findOrMakeTab()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64073 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 16:00:50 +00:00
Ingo Schommer
daaf05530c BUGFIX Fixed DebugView Breadcrumbs to not include query string as separate link, and don't append an arrow after the last element
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64072 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 13:05:37 +00:00
Ingo Schommer
d4c92e29b4 MINOR Removed CollectionController language strings from master table
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64068 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 12:14:06 +00:00
Ingo Schommer
9d596f6157 ENHANCEMENT Using i18n fieldlabels for column-headlines in TableListField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64067 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 12:13:23 +00:00
Normann Lou
a32b42fe19 BUGFIX: fix the bug that add some rules for summary columns even when they are not there.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64049 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 03:21:30 +00:00
Ingo Schommer
2b15a2d5b5 BUGFIX Using _t() to check content strings in unit tests and avoid tests failing when i18n is enabled
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64042 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 02:20:33 +00:00
Ingo Schommer
9b86763720 ENHANCEMENT Re-enabled RSSFeedTest - seems to work now due to Director::baseURL() fixes (#2861)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64041 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 02:19:55 +00:00
Sam Minnee
c69bea5329 MINOR: Removed subtree mergeinfo
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64020 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 21:00:24 +00:00
Ingo Schommer
d2e5662d47 MINOR Formatting
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64014 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 20:27:01 +00:00
Ingo Schommer
9a298e1592 BUGFIX Limited error message scope on invalid classname for TestRunner
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64013 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 18:49:24 +00:00
Ingo Schommer
ad3f0f400f ENHANCEMENT Improved error message on invalid classname for TestRunner
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64012 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 18:43:22 +00:00
Ingo Schommer
757e0ed755 BUGFIX Ignore TestOnly classes when collecting permissions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64011 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 18:16:13 +00:00
Ingo Schommer
54fa45c2fc BUGFIX Removed dependency of ss.i18n.js on other libraries by replacing $$ with document.getElementsByTagName() and implementing a custom event attacher - see #2927
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64010 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 17:58:56 +00:00
Ingo Schommer
617711c7e6 MINOR Swapped $mainFields and $fields assignments in Member->getCMSFields() to reflect what they're actually containing
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64009 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 17:31:32 +00:00
Ingo Schommer
53ba32a41a MINOR Syntax fix in CliTestReporter which was causing wrong array indices
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64008 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:17:59 +00:00
Ingo Schommer
18855687fc BUGFIX Making less assumptions about object structure in FieldSet->addFieldToTab() error messages
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64007 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:15:39 +00:00
Ingo Schommer
950560e188 MINOR Fixed PHP notice in CLITestReporter
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64006 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:14:31 +00:00
Ingo Schommer
eb5cd150d8 BUGFIX YamlFixture->saveIntoDatabase(): In order to support reflexive relations which need a valid object ID, the record is written twice: first after populating all non-relational fields, then again after populating all relations (has_one, has_many, many_many). Fixes a bug where FileTest was testing onBeforeWrite() behaviour
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64005 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:14:03 +00:00
Ingo Schommer
320c30ba5d BUGFIX Writing record from yml before parsing relations in YamlFixture->saveIntoDatabase() to avoid missing lookups for reflexive relations on the same object
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64004 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:07:34 +00:00
Ingo Schommer
06d78ee993 ENHANCEMENT Don't like relations without $api_access in RestfulServer, added RestfulServer->getAllowedRelations()
ENHANCEMENT Added DataFormatter->setCustomRelations()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64003 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:47:25 +00:00
Ingo Schommer
4134f92dad BUGFIX Moved RecordController and CollectionController to external module (see r63905)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64002 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:41:22 +00:00
Ingo Schommer
2fbed5b2e1 BUGFIX Adjusted FormTest->testLoadDataFromObject() to new assumptions about changed behaviour on loadDataFrom() from $loadBlanks to $clearMissingFields - which means that form fields are cleared regardless if they have blank values in the passed object or not
ENHANCEMENT Added FormTest->loadDataFromClearMissingFields() 
ENHANCEMENT Made FormTest fixtures more expressive 


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64001 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:40:13 +00:00
Ingo Schommer
5f50fee5e9 BUGFIX Making sure that DataObject->has*Field() methods always return an array, in order not to fail any array_key_exists() checks
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64000 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:39:24 +00:00
Ingo Schommer
b1b909103e BUGFIX Fixing DataObject->hasField() to find fields in inherited database tables by using hasDatabaseField().
BUGFIX Fixing DataObject->hasField() to detect dynamic getters by using hasMethod("get$fieldName") 
ENHANCEMENT Re-enabled two test cases in DataObjectSet as a result of the above fixes 


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63999 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:38:46 +00:00
Ingo Schommer
67f144e1a5 BUGFIX Fixed Form->loadDataFrom() to properly populate FormField->setValue() when an object is passed as the first parameter (needed e.g. for CheckboxSetField->setValue()) - see mailinglist discussion at http://groups.google.com/group/silverstripe-dev/browse_thread/thread/717bada8ccafdd70
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63998 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:37:46 +00:00