Ingo Schommer
dd7273b27a
MINOR Removed useless third argument to instantiation of itemClass in TableListField::generateExportFileData() (from r98544)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102768 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:20:28 +00:00
Ingo Schommer
c652311ce9
API CHANGE Made ComplexTableField not use Object::create() for item and popup classes to be consistent with TableListField. These can be overridden as itemClass and popupClass are public properties on ComplexTableField (from r98543)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102767 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:20:13 +00:00
Ingo Schommer
68ae667748
BUGFIX: Removed obsolete start argument from ComplexTableField_Item constructor. (from r98536)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102764 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:18:52 +00:00
Ingo Schommer
bfb10b849f
BUGFIX Fixed missing third argument to ComplexTableField_Item when the parent class instantiates it (from r98448)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102759 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:16:07 +00:00
Ingo Schommer
8256228e69
MINOR Upgraded jQuery.entwine (formerly known as jQuery.concrete) to the latest trunk
...
MINOR Updated jQuery.concrete references to point to the new "entwine" name
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102695 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 05:45:29 +00:00
Ingo Schommer
b3e30ac819
MINOR set Print flag correctly on TLF
...
MINOR custom print template for SSReport TLF's that exposes the report title, and filters set (from r97138) (from r98154)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102621 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:26:52 +00:00
Ingo Schommer
eba6c9b492
MINOR: Fixed TableListField tests that don't set $_REQUEST['url'] (from r97127) (from r98153)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102620 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:26:38 +00:00
Ingo Schommer
19f566675b
BUGFIX pagination was being applied (with a limit of NULL) to print and export actions. This was due to $_REQUEST['methodname'] not existing. (from r97114) (from r98152)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102619 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:26:27 +00:00
Ingo Schommer
64da35bca5
BUGFIX TreeMultiselectField_Readonly now posts the correct value to the server (from r97100) (from r98150)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102618 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:25:45 +00:00
Ingo Schommer
10537d5133
MINOR move sort column&direction into their own vars, otherwise, canSortBy(Date DESC) will always return false, since DESC is not part of the column name. (from r96411) (from r98137)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102609 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:34 +00:00
Ingo Schommer
be4c42f9d0
BUGFIX still use the correct methods to get a value, even if we're generating a CSV ($xmlSafe = false) (from r96212) (from r98136)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:21 +00:00
Ingo Schommer
4f461e4b99
MINOR fix field escaping in CSV export of TableListField (from r96157) (from r98135)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102607 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:08 +00:00
Ingo Schommer
f60c080337
BUGFIX: Don't default to sorted descending if you already have a different column sorted ascending. (from r96061) (from r98134)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102606 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:15:50 +00:00
Ingo Schommer
d743cdef78
BUGFIX: Make TableListField sort checking use SQLQuery::canSortBy() to let SSReprot_FakeQuery work.
...
ENHANCEMENT: Allow sort descending as well as ascending. (from r96054) (from r98132)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:15:23 +00:00
Ingo Schommer
21299ba686
ENHANCEMENT Allow user theme selection through SiteConfig, falling back to SSViewer::set_theme() as a default if there are none selected
...
MINOR Unit tests for SSViewer::current_theme() and SiteConfig::getAvailableThemes() (from r98110)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:13:12 +00:00
Ingo Schommer
4a2d71ae2a
BUGFIX: Allow creation of TreeDropdownFields on forms with querystring URLs.
...
API CHANGE: Allow passing of an explicit map of dropdown items to a TreeDropdownField.
BUGFIX: Make use of the $this->value setting of TreeMultiselectFields. (from r95910) (from r98101)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:09:32 +00:00
Ingo Schommer
453faed88a
API CHANGE: Refactored test for whether a SQLQuery can be sorted by a particular column into SQLQuery::canSortBy($fieldName) (from r95850) (from r98096)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:12 +00:00
Ingo Schommer
a78ffb7532
BUGFIX: Let FieldMap access non-data fields too (from r95825) (from r98095)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102587 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:57 +00:00
Ingo Schommer
da778dd2a9
BUGFIX: Make TableListField rely on SQLQuery for its count-generation.
...
BUGFIX: Make SQLQuery return an appropriate count if a HAVING clause is used. (from r95814) (from r98094)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102586 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:45 +00:00
Ingo Schommer
6848684334
MINOR: Initialise variables to fix unit test (from r95754) (from r98092)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102584 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:07 +00:00
Ingo Schommer
8ec4c25be7
MINOR: Don't try and access the ORM from ComplexTableField in situations where it shouldn't. (from r95544) (from r98089)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:01:59 +00:00
Ingo Schommer
fa5af56384
MINOR: Boundary condition check in TableListField for more helpful errors. (from r95543) (from r98088)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102580 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:01:39 +00:00
Ingo Schommer
5ba037cc04
BUGFIX: reintroducing the forceValue url param, so the TreeDropdownField value can be set via JS (previously if the item was deep within the tree structure it would not be selected) (from r98083)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:55:24 +00:00
Ingo Schommer
d4d3d63e99
BUGFIX: FileIFrameField throws sub-URLs error when changing cms to a non default language ( #4767 ) (from r97984)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102562 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:46:39 +00:00
Ingo Schommer
c24c9c89a2
BUGFIX: File don't have method URL(), instead, we use $image->URL, which will call $image->getURL() (from r97783)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102532 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:38:37 +00:00
Ingo Schommer
73ba193ad6
ENHANCEMENT: Select the uploaded image after uploading by default. #4962 (from r97765)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102531 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:36:50 +00:00
Ingo Schommer
d294c0f755
BUGFIX: add custom search function, so the search catches also the Titles (search uses DataObject::get, which bypasses the getMenuTitle function) (from r97755)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102530 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:34:08 +00:00
Ingo Schommer
6994e715ca
MINOR If CurrencyField->setValue() passed a null or empty value, default to 0.00 so number_format() has no issues converting the number (from r97566)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102509 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:59:55 +00:00
Ingo Schommer
7654557068
APICHANGE: removed SWFUpload. Refactored Content Editors uploader to use standard uploader. (from r97489)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:54:41 +00:00
Ingo Schommer
08b00bd5f4
MINOR Fixed setForm() invocation in Form::__construct() (see #4558 , thanks ajshort) (from r97483)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102498 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:19:38 +00:00
Ingo Schommer
051878c6a4
BUGFIX Fixed NumericField->jsValidation(), now accepts negative numbers, making it more like the equivalent phpValidation(), which is using is_numeric() (see #4874 , thanks Allisone) (from r97482)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102497 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:19:19 +00:00
Ingo Schommer
792deb3bad
MINOR Use addExtraClass() in FormField::__construct() instead of direct assignment (see #4607 , thanks Tjofras) (from r97481)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102496 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:19:01 +00:00
Ingo Schommer
fc77fb97f3
API CHANGE Moved GSTNumberField from sapphire/forms to new 'formfields_nz' module (from r97475)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102491 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:11:38 +00:00
Ingo Schommer
a46b205b0b
API CHANGE Moved BankAccountField from sapphire/forms to new 'formfields_nz' module (from r97474)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102490 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:10:47 +00:00
Ingo Schommer
d2e310a773
BUGFIX: getByKey replaced with objectForKey (from r97307)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102442 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 05:01:09 +00:00
Ingo Schommer
a36f4bdac7
MINOR: added comments (from r97072)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102430 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:36:56 +00:00
Ingo Schommer
3385ec012f
FEATURE: upgrading the search functionality of the TreeDropdownTree with pluggable search function
...
BUGFIX: the search was only operating on the part of the tree (as returned by markPartialTree), now it searches globally
MINOR: renamed 'filter' to 'search' (from r97031)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102424 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:33:56 +00:00
Ingo Schommer
2179389da3
BUGFIX: removed name attribute from label fields since this is invalid html. Ticket: #4887 . PATCH via tobych (from r97013)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102418 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:31:02 +00:00
Ingo Schommer
227bfffc0b
ENHANCEMENT: Added TabIndex to FormActions. Ticket: #4905 . PATCH: via keeny (from r97011)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102417 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:30:41 +00:00
Ingo Schommer
745a724b9e
MINOR Ensure DropdownField option elements have escaped the title correctly (from r96882)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102412 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:28:40 +00:00
Ingo Schommer
c077c77c25
BUGFIX: Use Controller::join_links() for all TableListField and ComplexTableField link building, to support form URLs with querystrings.
...
BUGFIX: If ComplexTableField::getParentRecord() can't find a record, just return null rather than erroring. (from r96555) (from r96649) (from r96775)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102407 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:27:03 +00:00
Ingo Schommer
89176afbc4
BUGFIX: Removed XSS holes (from r94823) (from r96773)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102402 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:21:00 +00:00
Ingo Schommer
7eb4e8ef83
BUGFIX: Fixed readonly form of TreeDropdownField when field is made readonly before value is set (from r94608) (from r96765)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102394 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:17:09 +00:00
Ingo Schommer
5bcfbe6622
BUGFIX: Allow opening of the detail pop-ups of a record on a ComplexTableField attached to a deleted page. (from r94593) (from r96762)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102393 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:16:54 +00:00
Ingo Schommer
1192b9ef2c
BUGFIX: Resized images which return null or false are now ignored (from r96754)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102383 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:45:35 +00:00
Ingo Schommer
21a6cf52cc
BUGFIX: Fixed reloading of TableFields after ajax save. ( http://mingle.silverstripe.com/projects/air_nz_cms_enhancements/cards/154 ) (from r88921) (from r96427)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102327 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:35:47 +00:00
Ingo Schommer
155cce25e5
BUGFIX: Readonly TreeMultiSelectField has form linked properly (from r96362)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102325 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:35:17 +00:00
Ingo Schommer
ddbc3e96b3
MINOR Fixed OptionsetField->disabledItems omission from r99596
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@99708 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-23 04:48:56 +00:00
Ingo Schommer
41c04fe61b
MINOR Making parameter optional for ComplexTableField_Item
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@99683 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-23 03:26:57 +00:00
Ingo Schommer
93895a4f0f
ENHANCEMENT Added OptionsetField->setDisabledItems() to allow specifically disabling certain checkboxes
...
ENHANCEMENT Added CheckboxSetField->setDefaultItems() to tick specified checkboxes regardless of the value passed
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@99596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-22 06:11:58 +00:00