Commit Graph

83 Commits

Author SHA1 Message Date
Ingo Schommer
8c1cc8fcc7 MINOR Reverted r78055, it breaks TableListFieldTest and doesn't actually fix the bug it was supposed to (PHP segfaulting)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@78083 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:28 +13:00
Hayden Smith
cbac70612a Fixed a phpsefault
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@78055 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:28 +13:00
Will Rossiter
17b759ba12 BUGFIX: fixed is_array error in TableListField. #4123
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@77937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:27 +13:00
Andrew O'Neil
b105a252e2 MINOR: Ensure TableListField takes searching into account when adjusting
the sort


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@77071 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:25 +13:00
Andrew O'Neil
933468aa8c Fix a PHP segfault
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@77051 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:25 +13:00
Sean Harvey
63aba66eec BUGFIX TableListField items couldn't be deleted because TableListField_ItemRequest::__construct() didn't call parent::__construct()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@77016 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:25 +13:00
Sam Minnee
8c24a42cb8 BUGFIX: Made TableListField::export() more memory efficient for large exports.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@76702 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:23 +13:00
Ingo Schommer
9999f8edd8 BUGFIX Moving Requirements for TableField, TableListField, ComplexTableField, ScaffoldComplexTableField and HasManyComplexTableField from __construct() into FieldHolder() and renderWith(), which means inclusion closer to render time, and less side-effects by a previous Requirements::clear(), e.g. in a CTF popup
ENHANCEMENT Removed constructor overloading in ScaffoldingComplexTableField, was reconstrcuting its own Requirements (with lots of unnecessary jQuery plugins) which should really be done by the individual form fields and the parent popup class

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74919 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:15 +13:00
Sam Minnee
8dc652aaa8 BUGFIX: Updated i18n javascript system so that the i18n javascript needs to be explicitly included, so that it doesn't poke its nose in where it's not wanted.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@72563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:09 +13:00
Normann Lou
c9df0ee039 BUGFIX:
1. TableListField? exportfunality random bug. 
2. make Email_BounceRecord::canCreate() return false; so that it can not be manully create from CRM, instead, it should create through email buncing system.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70747 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
b114900053 BUGFIX: 1. TableListField exportfunality random bug. 2. make Email_BounceRecord::canCreate() return false; so that it can not be manully create from CRM, instead, it should create through email buncing system.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70743 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
b9145ab995 BUGFIX:
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70741 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
85abd8664b Undoing change committed in r 70734
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70740 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
d7f67183c6 git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70734 467b73ca-7a2a-4603-9d3b-597d59a354a9 2011-02-02 14:27:03 +13:00
Saophalkun Ponlu
5ddb00dfa3 BUGFIX: when the total number of rows is 0 the pagination says 1 to 0 of 0
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70565 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:01 +13:00
Sean Harvey
9c4552efa3 MINOR Fixed undefined variable error in TableListField->generateExportFileData()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70257 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:00 +13:00
Normann Lou
d3a5bcbb7f APICHANGE: we move the filedata generation part of export() function to a new function generateExportFileData, so that, a child class could reuse the function when overload export function
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70150 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:59 +13:00
Hayden Smith
17a55042ca BUGFIX: Fixed a check for CSV field formatting.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:46 +13:00
Sean Harvey
c96d891c2c MINOR Removed whitespace after ?> end PHP tag
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67467 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:45 +13:00
Sam Minnee
3a619d8dbb Add TableListField::setFieldList()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67169 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:41 +13:00
Ingo Schommer
916df369d8 BUGFIX Consistenly returning cloned instances for all FormField classes when calling performReadonlyTransformation() or performDisabledTransformation(). Making sure that these instances are actually flagged as readyonly/disabled. Addd unit tests to dynamically instanciate most FormField classes to check for this behaviour. Originally, this bugfix was necessary to avoid changed FormField state when recursively calling replaceField() on FieldSet->dataFields() in Translatable->updateCMSFields()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:36 +13:00
Will Rossiter
a92d2120a1 Merged pre-2.3-oct08 into branches/2.3 (via trunk)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66084 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:33 +13:00
Sam Minnee
cd699e3d89 API CHANGE #2857 - Renamed RequestHandlingData to RequestHandler
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64953 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-30 22:03:21 +00:00
Ingo Schommer
9d596f6157 ENHANCEMENT Using i18n fieldlabels for column-headlines in TableListField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64067 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 12:13:23 +00:00
Sean Harvey
d794b11910 BUGFIX Added missing slash in TableListField_Item->Link()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63945 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 02:20:35 +00:00
Sam Minnee
51447b89ab BUGFIX: Fixed pagination in TableListField after hsmith's changes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:32:33 +00:00
Hayden Smith
634ed7b70c Merged from branches/nzct-trunk. Use 'svn log -c <changeset> -g' for full commit message. Merge includes stability fixes and minor refactor of TableListField and ComplexTableField.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63806 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:00:12 +00:00
Ingo Schommer
82d6b7e640 BUGFIX Escaping added database columns in queries for TableListField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63618 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 15:57:01 +00:00
Sam Minnee
7fbeb7d6c5 BUGFIX: Fixed ComplexTableField export
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 02:25:49 +00:00
Ingo Schommer
6bd34d3e53 ENHANCEMENT Using ss.i18n in all sapphire form fields with clientside language strings
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63567 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 00:47:08 +00:00
Ingo Schommer
2c11afb2df BUGFIX wrong jsparty PATH references
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63296 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 18:49:55 +00:00
Ingo Schommer
9371f4688b ENHANCEMENT Introduced constants for system paths like /sapphire in preparation for a more flexible directory reorganisation. Instead of hardcoding your path, please use the following constants: BASE_PATH, BASE_URL, SAPPHIRE_DIR, SAPPHIRE_PATH, CMS_DIR, CMS_PATH, THIRDPARTY_DIR, THIRDPARTY_PATH, ASSETS_DIR, ASSETS_PATH, THEMES_DIR, THEMES_PATH
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63154 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 16:02:38 +00:00
Sam Minnee
ed311db3bf ENHANCEMENT: ComplexTableFilters used to edit relations have their filter automatically set, as well as the foreign key on new records.
API CHANGE: TableListField::sourceFilter() can be overloaded to change the querying logic.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62883 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-23 01:24:03 +00:00
Sam Minnee
0075040f87 API CHANGE: TableListField::ajax_refresh is deprecated. Removed all calls to it from the core, instead getting HTML fragments by visiting the field's URL.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61683 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-28 04:14:22 +00:00
Sam Minnee
556031ce34 Fixed bug in TableListField::ajax_refresh
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61613 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-27 04:58:08 +00:00
Normann Lou
6a897d7bfa getSummaryFields() will also get those summary fields defined in Member's decorator applied to the results and export
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61509 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-26 01:45:52 +00:00
Sean Harvey
09af15d382 BUGFIX sourceFilter should be a string, not an array
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61162 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:13:53 +00:00
Sam Minnee
ec9a40ee50 Fixed bug in TableListField sort links
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61065 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:07:28 +00:00
Saophalkun Ponlu
505fef0791 Removed double quoute from the from fields as it means field terminator
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 04:23:24 +00:00
Saophalkun Ponlu
ffb5d82bc2 replaced <br /> with newline for CSV export
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60907 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:41:38 +00:00
Ingo Schommer
c706dbdcc1 BUGFIX Fixed TableListField->Link() to allow for instanciation without a form/controller (e.g. for unit tests)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60757 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 08:19:02 +00:00
Ingo Schommer
16a5b9b745 BUGFIX Fixed partial merge from nzct (originally from r47039, partially merged in r60440)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 04:38:22 +00:00
Sam Minnee
cb86fdb3d1 BUGFIX: Fixed bug with unpaginated TableListFields. Added tests for TableListField pagination
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60573 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 01:39:46 +00:00
Hayden Smith
8447e7fca5 Refactored [47092]: Add TableListField::getCastedValue
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60543 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 23:04:14 +00:00
Hayden Smith
9852fd104b Merged [47080]: Fix for pagination when using customSourceItems in TableListField.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60514 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 21:48:07 +00:00
Hayden Smith
41ebffce4f Merged [47073]: Fix for pagination in TableListField::sourceItems.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60508 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 21:14:06 +00:00
Hayden Smith
130ecfe5aa Merged [47044]: Introduces modifications to Sapphire's form handling that allows it to ignore fields marked as Disabled when saving the contents of a form's fields to a DataObject.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60469 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 02:58:48 +00:00
Sam Minnee
0bd9bc4ff8 Merged changes from 2.2.2-assets - everything except the asset refactoring
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60468 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 02:51:33 +00:00
Sam Minnee
b5001bc906 Allow object-methods to be used as columns in TableListField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60448 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 00:12:29 +00:00
Hayden Smith
1220f6d86d Merged [47039]: Introduces custom actions to TableListField and ComplexTableField. By default, the show, edit and delete actions are included.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60433 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-11 23:24:54 +00:00