Dylan Wagstaff
92061a3ba6
FIX stabilise typed APIs ( #10740 )
...
Since 4.12 the use of typehints and return types has caused issues with
values fetched directly from config without validation. This has lead to
upgrade woes in a minor version (#10721 ) with no immediate recourse
other than manual system intervention.
To use types, we should ensure types, leaving a stable API that won't
error on a bad value - or should give a thoughtful and directive error
message if so.
Issue #10721 summary:
SessionMiddleware runs before FlushMiddleware
SessionMiddleware causes a PHP fatal error passing `null` to a `string`
parameter.
`null` comes from config, because default string value doesn't exist. We
need flush for this - but system execution never makes it that far.
2023-04-11 10:52:41 +12:00
Guy Sartorelli
a42bb856c3
Merge pull request #10750 from xini/patch-6
...
FIX: Group visibility for SITETREE_GRANT_ACCESS permissions
2023-04-11 09:58:43 +12:00
Florian Thoma
cd946b6c80
Group visibility for SITETREE_GRANT_ACCESS permissions
...
Make groups visible if member has SITETREE_GRANT_ACCESS permissions, otherwise the dropdown for selecting the group is empty
2023-04-05 16:33:41 +10:00
Steve Boyd
63c2460f72
Merge branch '4' into 5.0
2023-03-30 13:20:03 +13:00
Guy Sartorelli
d30cd6f68e
Merge pull request #10736 from creative-commoners/pulls/pulls/5.0/double-sort/pulls/5.0/double-filter
...
FIX Remove legacy filter icon
2023-03-29 10:37:50 +13:00
Steve Boyd
c278576996
Merge branch '4.13' into 4
2023-03-29 09:52:38 +13:00
Guy Sartorelli
600f188287
MNT Revert erroneous dependency changes ( #10739 )
2023-03-28 16:46:46 +13:00
Steve Boyd
84273b8045
FIX Remove legacy filter icon
2023-03-27 17:57:02 +13:00
Maxime Rainville
3a7fd429a9
Merge pull request #10731 from creative-commoners/pulls/4/dispatch-ci
...
MNT Use gha-dispatch-ci
2023-03-23 14:10:11 +13:00
Guy Sartorelli
a62e554409
Merge pull request #10733 from creative-commoners/pulls/4.13/searchable
...
FIX Respect searchable_fields
2023-03-23 11:51:02 +13:00
Steve Boyd
0f40cc38ec
FIX Respect searchable_fields
2023-03-23 10:57:03 +13:00
Guy Sartorelli
0d041e7d7d
Merge pull request #10730 from creative-commoners/pulls/4.13/fix-depr
...
FIX Reduce array method calls
2023-03-22 11:34:10 +13:00
Maxime Rainville
62f6177ec1
Merge pull request #10732 from creative-commoners/pulls/5.0/embed
...
API Remove configurability of attributes
2023-03-22 11:30:34 +13:00
Steve Boyd
41bb35f3f3
FIX Reduce array method calls
2023-03-22 11:06:23 +13:00
Steve Boyd
b4f330d734
API Remove configurability of attributes
2023-03-21 16:38:05 +13:00
Steve Boyd
241b58cd65
MNT Use gha-dispatch-ci
2023-03-21 14:22:01 +13:00
Guy Sartorelli
e47eedff7d
Merge pull request #10725 from zemiacsik/patch-ArrayList-fix
...
FIX property_exists() parameters mixup
2023-03-20 18:52:02 +13:00
Guy Sartorelli
f7e86812df
Merge pull request #10726 from creative-commoners/pulls/5.0/pdo
...
MNT Remove references to PDO
2023-03-20 11:20:51 +13:00
Steve Boyd
9f250cf772
MNT Remove references to PDO
2023-03-16 10:59:34 +13:00
zemiacsik
d60af9d16e
FIX property_exists() parameters mixup
...
ensure that property parameter is a string
2023-03-14 08:42:22 +01:00
zemiacsik
5b8d61b55b
FIX property_exists() parameters mixup
...
property_exists() has first parameter "object_or_class" and second is a property to check
2023-03-13 13:51:48 +01:00
Guy Sartorelli
77cbe20ba9
MNT Update development dependencies
2023-03-10 16:29:44 +13:00
Guy Sartorelli
75b7622a21
MNT Update release dependencies
2023-03-10 16:29:40 +13:00
Guy Sartorelli
a387c9b9e4
MNT Update development dependencies
2023-03-10 12:21:27 +13:00
Guy Sartorelli
a4929a171e
Merge pull request #10697 from creative-commoners/pulls/4/nicer-deprecations
...
ENH Improve deprecation logging
2023-03-09 14:39:51 +13:00
Steve Boyd
d860cb6556
Merge branch '4' into 5.0
2023-03-08 12:20:24 +13:00
Guy Sartorelli
f29577853a
Merge pull request #10720 from creative-commoners/pulls/4/tx-1678079865
...
ENH Update translations
2023-03-08 10:25:02 +13:00
Steve Boyd
a37be27bd7
ENH Update translations
2023-03-06 18:17:45 +13:00
Guy Sartorelli
a0b3eaddc0
Merge pull request #10719 from creative-commoners/pulls/5.0/remove-depr
...
API Remove deprecated code
2023-03-06 14:44:33 +13:00
Steve Boyd
6d239d0b88
API Remove deprecated code
2023-03-06 14:06:02 +13:00
Guy Sartorelli
046befc4ba
ENH Improve deprecation logging
2023-03-06 13:25:44 +13:00
Guy Sartorelli
128b327c6d
API Add method to check if env var is set
2023-03-06 11:49:22 +13:00
Guy Sartorelli
bdf90fb80d
Merge pull request #10716 from creative-commoners/pulls/5.0/remove-deprecation
...
MNT Remove old deprecation warnings
2023-03-03 11:21:09 +13:00
Maxime Rainville
9868eca7eb
DEP Bump masterminds/html5 to 2.7.6 to fix deperaction warning ( #10714 )
2023-03-03 10:48:49 +13:00
Steve Boyd
5dd6e3f8f1
MNT Remove old deprecation warnings
2023-03-03 10:34:10 +13:00
Steve Boyd
f6d8d27c89
Merge branch '4' into 5.0
2023-03-02 16:02:34 +13:00
Steve Boyd
8b148bf293
Merge branch '4.12' into 4
2023-03-02 15:37:03 +13:00
Guy Sartorelli
66561ccb49
FIX Correctly deprecation Sources.module_priority ( #10711 )
...
This config was deprecated back in #7154 and hasn't been used since
2023-03-02 11:05:35 +13:00
Maxime Rainville
403f924d22
BUG Update RelatedDataService to properly escape ClassName in Polymorphic relations ( #10713 )
2023-03-02 09:56:40 +13:00
Michal Kleiner
94b24b2390
Merge pull request #10687 from xini/fix-classinfo-paths-windows
2023-03-01 20:56:49 +13:00
Florian Thoma
6585d499f5
FIX Convert slashes in paths when getting list of classes for file/folder
...
This is to support the mechanism working on all operating systems where Windows may produce a mix of forward and backward slashes in some paths.
For working with the files it may not be a problem, but for exact string comparison the path delimiters need to be unified.
2023-03-01 20:32:19 +13:00
Guy Sartorelli
e3a94b9d10
FIX Ensure getters and setters are respected ( #10708 )
2023-03-01 15:19:07 +13:00
Guy Sartorelli
277e97a84f
Merge pull request #10709 from creative-commoners/pulls/4/deprecated-args
...
ENH Updated deprecation warning message
2023-03-01 14:19:18 +13:00
Guy Sartorelli
58ca426f11
Merge branch '4.12' into 4
2023-03-01 12:54:30 +13:00
Sabina Talipova
05674adf51
ENH Updated deprecation warning message
2023-03-01 12:39:42 +13:00
Guy Sartorelli
5295ba6c16
API Throw deprecation warnings for bad configuration ( #10702 )
2023-03-01 11:36:08 +13:00
Guy Sartorelli
6669d54f59
FIX Wrap deprecated config with no replacement ( #10704 )
2023-02-27 18:13:31 +13:00
Guy Sartorelli
652281507f
FIX Correctly identify deprecated API in withNoReplacement ( #10706 )
2023-02-27 15:25:27 +13:00
Guy Sartorelli
981e20e298
Merge pull request #10700 from silverstripeltd/pulls/kernel-is-flushed
...
5-beta: Add isFlushed() to Kernel interface
2023-02-23 11:27:06 +13:00
Chris Penny
c82d11ef70
Add isFlushed() to Kernel interface
...
Also add explicit return type
2023-02-23 11:14:57 +13:00
