ce58890baf
Merge branch '4.0' into 4.1
2018-06-11 09:27:42 +01:00
c070e989c4
BUG Safely handle empty injector factory responses
...
Fixes issue with ImageBackendFactory returning null and breaking injector
2018-06-06 16:45:16 +12:00
ea16e28aa7
Merge branch '4.1' into 4
2018-05-28 18:33:56 +12:00
3a537bc745
Merge branch 'heads/4.0.4' into 4.0
2018-05-28 17:50:07 +12:00
722202fef4
Merge remote-tracking branch 'origin/4.0.4' into 4.1.1
...
# Conflicts:
# src/Control/Director.php
2018-05-24 15:41:11 +12:00
d935140a95
[ss-2018-005] Prevent unauthenticated isDev / isTest being allowed
2018-05-14 17:03:39 +12:00
7351caf487
API Allow non-DataExtension Extensions to decorate dataobject
2018-03-23 12:22:27 +13:00
26402f3bb5
ENHANCEMENT Enable request handlers to be extended
2018-03-21 15:50:31 +13:00
1cdbab45c9
Added comment about array_merge() not working
2018-02-27 09:52:42 +13:00
0863bac29a
Update getVariables to return a copy of globals rather than including the reference in an array merge
2018-02-27 09:52:36 +13:00
f650c92436
Added comment about array_merge() not working
2018-02-26 12:24:02 +13:00
d91648dd6e
Update getVariables to return a copy of globals rather than including the reference in an array merge
2018-02-23 16:25:41 +13:00
e809c0fd62
Merge remote-tracking branch 'origin/4.0' into 4.1
2018-02-15 09:27:51 +13:00
0b7cf80331
BUG Fix incorrect convert slashes argument
2018-02-13 16:33:35 +13:00
9ce21338a3
ENHANCEMENT composer.json missing notice
2018-02-13 09:03:01 +10:00
62057befdb
Merge branch '4.0' into 4
2018-02-06 10:08:17 +00:00
28ca11dd7e
FIX Regex range identifier correctly escaped
2018-02-05 15:17:20 +00:00
e359948eb3
Merge remote-tracking branch 'origin/4.0' into 4
...
# Conflicts:
# src/Core/CoreKernel.php
2018-02-05 17:52:38 +13:00
cb30e09130
Update reference from $databaseConfig to .env
2018-02-01 12:58:55 +13:00
cd6faac7a9
FIX Fix typo in error message
2018-01-30 15:48:42 +13:00
a3c52f901a
Merge remote-tracking branch 'origin/4.0' into 4
...
# Conflicts:
# src/Core/TempFolder.php
# src/ORM/DataObject.php
# src/View/ThemeResourceLoader.php
# src/includes/constants.php
# tests/php/Control/SimpleResourceURLGeneratorTest.php
# tests/php/Forms/HTMLEditor/HTMLEditorFieldTest.php
# tests/php/View/RequirementsTest.php
2018-01-22 14:57:05 +13:00
db610aaf3b
Fixing string concat CS issues
2018-01-16 18:39:30 +00:00
e4b936c7c7
Merge branch '4.0' into 4
2018-01-12 14:40:33 +00:00
8d077203d4
API Implement support for public/ webroot folder ( #7741 )
...
* API Implement support for public/ webroot folder
* Bugfixes and refactor based on feedback
2018-01-12 16:25:02 +13:00
7d66342496
FIX Allow extension instances to be overridden by injector
2018-01-12 00:38:15 +00:00
529e341dbc
Merge pull request #7699 from open-sausages/pulls/4/html-in-security-msg
...
ENHANCEMENT Allow html in security failure message
2017-12-14 14:30:09 +13:00
1c8576cee7
Linting cleanup
2017-12-14 14:18:41 +13:00
8b1b9f022b
Fix linting issues
2017-12-14 13:50:52 +13:00
ee27329728
Minor linting / style updates
2017-12-11 16:46:59 +13:00
86458941be
Refactor to MemberCacheFlusher
2017-12-11 16:46:59 +13:00
eecb9f64d3
Add new InheritedPermissionFlusher extension, CacheFlusher service
2017-12-11 16:46:59 +13:00
eb55c27124
Merge branch '4.0' into 4
2017-12-05 12:14:22 +00:00
9666222637
BUG Fix _configure_database.php being ignored
...
Fixes #7590
2017-11-29 12:01:24 +13:00
6d5cbe0a0e
Merge branch '4.0' into 4
2017-11-25 17:19:31 +00:00
3620e57b5b
check for apc.enable_cli when running from CLI
2017-11-22 08:50:20 +00:00
420041f2b6
Merge remote-tracking branch 'origin/4.0' into 4
2017-11-03 17:04:44 +13:00
9c836c0d3d
Added missing @deprecated tags
...
This PR just adds a couple of @deprecated tags where they were missing, where IDE's like PHPStorm immediately alert the user that it's deprecated.
2017-11-02 20:28:01 +13:00
0b3ed7ff15
Merge 4.0 -> 4
2017-11-02 16:52:05 +13:00
df50c8da03
BUG Use parse_str in place of guzzle library
...
Fixes #7540
2017-11-02 11:52:39 +13:00
29af6dbafd
Merge remote-tracking branch 'origin/4.0' into 4
2017-10-25 16:59:19 +13:00
ff992de231
Merge pull request #7493 from kinglozzer/require-me-some-isolation
...
FIX: Use isolated scope when requiring files for module activation
2017-10-24 14:19:37 +13:00
4bec62ba51
Merge branch '4.0' into 4
2017-10-20 18:45:16 +13:00
b9cb1e69e6
BUG Replace phpdotenv with thread-safe replacement
2017-10-20 18:43:11 +13:00
bb9501797f
FIX: Use isolated scope when requiring files for module activation
2017-10-20 09:11:00 +13:00
cafa3fc29a
BUG switch to `trigger_error()` when a resource is not found ( #7468 )
...
* BUG switch to `trigger_error()` when a resource is not found rather than throw an exception
* Add unit test for module url failing
2017-10-16 16:11:42 +13:00
7afab3043d
Merge pull request #7461 from open-sausages/pulls/4.0/fix-icon-urls
...
Fix references to resource paths / urls
2017-10-10 09:08:08 +01:00
6a55dcfc16
Fix references to resource paths / urls
2017-10-10 16:51:47 +13:00
11b2c74533
ENHANCEMENT Improve upgrade experience for beta3 -> beta4 upgrade
2017-10-10 15:27:41 +13:00
4a94dfe55b
Remove "url" query param reliance, use index.php
...
See https://github.com/silverstripe/silverstripe-framework/issues/7430
2017-10-09 17:21:43 +13:00
3560a0418d
rename TEMP_FOLDER to TEMP_PATH
2017-10-09 12:41:34 +13:00
313f8c7ac3
Merge pull request #7439 from creative-commoners/pulls/4.0/trim-injector-names
...
FIX Trim whitespace off names in Injector
2017-10-09 12:31:11 +13:00
3bdc8c7e65
FIX Trim whitespace off names in Injector
2017-10-06 15:52:44 +13:00
b996e2c22c
API Extensions are now stateless
...
ENHANCEMENT Injector now lazy-loads services more intelligently
2017-10-06 14:53:44 +13:00
4dbd727206
BUG Config updates are now applied after middleware not before
2017-10-05 12:30:21 +13:00
1b6d0144c5
BUG Fix resource mapping for TinyMCE
...
API add ModuleResource::getRelativeResource()
2017-10-04 17:44:04 +13:00
f4a77649a4
Fix requirements tests
2017-10-03 14:21:24 +13:00
5ffe64f024
Fix tinymce plugins
2017-10-03 14:08:24 +13:00
f64c95b33c
Add new ModuleResourceLoader helper
2017-10-03 12:20:49 +13:00
26f7f0482c
Fix typos in FilesystemCacheFactory
2017-10-02 15:10:44 +13:00
fa57deeba4
ENHANCEMENT Allow vendor modules with url rewriting
...
API Introduce ModuleResource feature
2017-09-29 10:28:38 +13:00
da27948777
Merge pull request #7373 from dhensby/pulls/4/rate-limit-security
...
NEW RateLimiter for Security controller
2017-09-28 11:01:37 +13:00
51ac297c59
Fixes to ratelimiter and new features
2017-09-27 14:44:38 +01:00
261302a121
ENHANCEMENT Don't force all class names to lowercase
...
Speeds up autoloading because composer psr-4 works properly now
2017-09-20 15:14:55 +12:00
04b1bb816e
NEW RateLimiter for Security controller
2017-09-14 14:23:36 +01:00
45998444d7
Remove redundant gc_collect_cycles()
...
Cleanup dead references to DataObject::$destroyed
Fixes #7326
2017-09-04 09:23:07 +12:00
47fced8880
BUG Capture errors after a reload token redirect to login url
...
Fixes #7289
2017-08-24 12:55:04 +12:00
9b4d689bb2
Lazy-load custom methods and extensions on CustomMethods and Extensible traits
...
No longer need constructExtensions()
2017-08-22 15:47:24 +12:00
fc2a603915
BUG Don’t construct extension_instances on objects that never use them
2017-08-22 15:47:24 +12:00
90ba24733d
Reduce unnecessary calls to Extension and DataExtension configs
2017-08-22 15:47:24 +12:00
c50cd34df6
FIX: Prevent repeated lookup of obj.dependencies by Injector
...
This unnecessary repeated call to Injector slows down the construction
of frequently instantiated classes.
On admin/pages, this reduced execution from 1.67s to 1.56s, and it
reduced the impact of having an extension added to DBField by 33%
(from 100ms to 67ms)
2017-08-22 12:12:32 +12:00
0681567102
BUG Fix flushing on live mode ( #7241 )
...
* BUG Fix flushing on live mode
Fixes #7217
* Clarify injector service documentation
2017-08-07 13:53:23 +12:00
c9cf7b1d75
Use ClassInfo::hasMethod instead of method_exists()
...
This allows for setters to exist in extension instances.
2017-07-30 22:43:28 +12:00
6fd6a38949
BUG Fix unassigned nestedFrom
...
Fixes #7194
2017-07-21 08:58:19 +12:00
d7095c2213
Merge branch '3' into 4
2017-07-18 14:19:16 +01:00
ba9ad55274
FIX Base URL defaults to a slash in currentURL if not defined already
2017-07-18 21:56:21 +12:00
1a38feff22
FIX Version provider uses early bound config getter, move LeftAndMain config to admin module
2017-07-16 16:49:10 +12:00
7fd316d405
Merge branch 3 into 4
2017-07-15 13:20:37 +01:00
aafd2a573d
Update Convert::memstring2bytes() logic
2017-07-14 09:16:05 +01:00
5fcd7d084f
BUG Fix registered shutdown function not handling responsibility for outputting redirection response
2017-07-13 15:32:39 +12:00
2b266276c2
API Implement new module sorting pattern
2017-07-13 10:27:27 +12:00
e3e16fe835
Cache ClassInfo::class_name() calls
2017-07-05 15:15:08 +01:00
b2f3b218a3
BUG Fix incorrect $database autoinit
...
BUG Fix missing $request in Installer bootstrapping
2017-06-28 17:59:16 +12:00
741166e369
API: ModulePath template global now takes any composer package name.
...
NEW: URL generation now handled by pluggable ResourceURLGenerator service.
NEW: Requirements::javascript() and Requirements::css() now support “vendor/package:resource” syntax.
These changes will make it easier to us to fully abstract:
- file access from module location
- file location from URL generation
API: ModulePath template global now takes any composer package name.
NEW: URL generation now handled by pluggable ResourceURLGenerator service.
NEW: Requirements::javascript() and Requirements::css() now support “vendor/package:resource” syntax.
These changes will make it easier to us to fully abstract:
- file access from module location
- file location from URL generation
2017-06-28 16:59:28 +12:00
ecb5d85de0
Support empty SS_DATABASE_PREFIX
2017-06-28 08:18:21 +12:00
f699650b5f
Update based on feedback
2017-06-27 13:32:39 +12:00
d20ab50f9d
API Stronger Injector service unregistration
...
BUG Fix up test regressions
FIX director references to request object
API Move all middlewares to common namespace
API Implement RequestHandlerMiddlewareAdapter
ENHANCEMENT Improve IP address parsing
Fix up PHPDoc / psr2 linting
BUG Fix property parsing in TrustedProxyMiddleware
BUG Fix Director::is_https()
2017-06-27 13:32:39 +12:00
e92c63c545
API: Remove $sid argument of Session::start()
...
NEW: Pass HTTPRequest to session
NEW: Pass HTTPReuqest optionally to Director statics
The session handler now expects to operate on a specific
HTTPRequest object.
2017-06-27 13:32:39 +12:00
e855622890
NEW: Replace FlushRequestFilter with FlushMiddleware
2017-06-27 13:32:39 +12:00
26b9bf11ed
NEW: Allow “%$” prefix in Injector::get()
...
Injector::get() looks up services by name. In yaml config it can make
things clearer to prefix service names by %$, which is how they must
be prefixed when referencing nested services within service definitions.
This change means that any other system referencing services will
support an optional prefix without needing to specifically code support
in themselves.
2017-06-27 13:32:39 +12:00
17c8e913bc
Merge pull request #7053 from creative-commoners/pulls/4.0/restore-extension-constructor
...
NEW restored Extension::__construct()
2017-06-26 21:39:55 +12:00
d3d426bdfc
NEW restored Extension::__construct()
2017-06-26 17:34:43 +12:00
3c35d25a64
FIX: Allow DB::setConfig() in _config.php
...
This wasn’t working because the database was being validated before
_config.php was loaed.
This is how the installer sets config so this is an important fix.
2017-06-26 14:04:20 +12:00
3873e4ba00
API Refactor bootstrap, request handling
...
See https://github.com/silverstripe/silverstripe-framework/pull/7037
and https://github.com/silverstripe/silverstripe-framework/issues/6681
Squashed commit of the following:
commit 8f65e5653276f95944fa9379834cb4188ce35d827ed4660e7a738f50c4976279d28e5e5c90d53a84f9b2ba47555b59a912b6e2c4a18f635d235e64f3d88d4ed4e4f7946aec3312bd31f936bba97911462a10c2397bd75a8d1d9306364af3c32a278e2953b65c21241bd1d4375c95b220534f06603704165c2f6336a15bfc7188da7da0ae723514ca03395251c66d433977f26ae75c6e001d559662de079c041d
2017-06-22 22:50:45 +12:00
7178caf4a9
Enhancement show the path which threw the error
2017-06-12 10:08:12 +12:00
8f44b8f0ba
move trusted_proxy_ips below .env loader
2017-05-30 12:18:47 +01:00
29f450b1e1
Revert injector type hint to Injector
2017-05-25 11:06:48 +12:00
fba8e2c245
API Remove Object class
...
API DataObjectSchema::manyManyComponent() return array is now associative array
2017-05-23 13:50:35 +12:00
7e2f8d1f2d
Merge pull request #6951 from sminnee/fix-2494
...
FIX: Don’t assume posix_getpwuid is available.
2017-05-23 13:10:56 +12:00
09164e7e2a
FIX: Better error checking for non-writable temp paths
...
Fixes https://github.com/silverstripe/silverstripe-framework/issues/1666
2017-05-23 10:06:48 +12:00
40d9bbfd69
FIX: Don’t assume posix_getpwuid is available.
...
Fixes https://github.com/silverstripe/silverstripe-framework/issues/2494
In Silverstripe 3.1, on some shared hosts the following bug can occur:
Warning: posix_getpwuid() has been disabled for security reasons
2017-05-23 10:00:36 +12:00
a433e5f4a8
Find root modules with _config.php
...
When modules are installed as the webroot,
manifest generation should behave the same way as when they're in a subfolder.
Which means accepting the module folder both with a _config/ folder
and a _config.php file present.
2017-05-22 12:16:57 +12:00
2aa3b5d5fa
Merge pull request #6934 from robbieaverill/pulls/4.0/consistent-instance-method
...
API Consistent use of inst() naming across framework
2017-05-22 11:57:20 +12:00
f2cbe86f03
Remove CustomMethods::createMethod and create_function implementations, replace with closures
2017-05-19 15:56:44 +12:00
ad43a82923
API Consistent use of inst() naming across framework
2017-05-19 14:38:06 +12:00
100048da33
API PSR-11 compliance ( fixes #6594 ) ( #6931 )
...
Note that our usage of `$asSingleton` in `get()` is fine. Quote from the PSR:
> Two successive calls to get with the same identifier SHOULD return the same value. However, depending on the implementor design and/or user configuration, different values might be returned, so user SHOULD NOT rely on getting the same value on 2 successive calls.
2017-05-19 13:45:07 +12:00
259f957ce8
API Rename services to match FQN of interface / classes
2017-05-16 14:15:49 +12:00
8b9f41d4f4
BUG Fix ApcuCache and MemCache namespace
2017-05-04 12:17:33 +12:00
2548bfba1e
API Replace SS_HOST with SS_BASE_URL
...
API Remove Director::$test_servers / $dev_servers
API Remove MODULES_PATH / MODULES_DIR constants
ENHANCEMENT Injector backtick syntax now supports environment variables as well as constants
Fixes #6588
2017-04-20 22:28:57 +12:00
ac9d645e4e
Root-level module support in Module->getResourcePath()
...
See https://github.com/silverstripe/silverstripe-framework/pull/6733
2017-03-29 10:19:31 +13:00
e08948480c
Remove File dependency from Module class
2017-03-28 17:26:23 +13:00
556c9a537e
Module->getResourcePath()
...
Based on Sam's feedback in https://github.com/silverstripe/silverstripe-framework/pull/6733
2017-03-28 17:22:30 +13:00
874c6ccdd4
API Add experimental getResource() to Module
2017-03-28 14:13:47 +13:00
dae6d5902f
API Split SilverStripe\Assets into separate module
2017-03-21 11:12:51 +13:00
54ba08a306
API Replace ManifestCache with ManifestCacheFactory
...
API Remove lots of deprecated module code from ClassManifest
2017-03-21 09:43:48 +13:00
ce14060913
API Apply default logger to all caches
...
API Rename ‘Logger’ service name to ‘Psr\Log\LoggerInterface’
API DefaultCacheFactory constructor now takes an array of default arguments
2017-03-15 15:31:24 +13:00
8f0f9fa119
API Apply logging to config cache
2017-03-15 15:31:24 +13:00
810dcab748
Simplify config for admin removal
2017-03-14 10:22:45 +13:00
0c41a97a8b
API Refactor Form request handling into FormRequestHandler
...
API Add HasRequestHandler interface
API Refactor Link() and url handling behaviour from Controller into RequestHandler
API RequestHandler classes now must define url_segment to have a default Link()
API Clean up redirectBack()
2017-03-10 15:04:33 +13:00
cdb4a86e1c
PHPParser optimisations and update
2017-03-06 10:35:25 +00:00
f8e3443c89
Initial PHP Parser implementation
2017-03-06 10:19:00 +00:00
d01da57da1
Merge pull request #6674 from oilee80/master
...
Fix for APCu cache otherwise you get 'Cache key must be string, "bool…
2017-03-03 12:17:06 +00:00
263e747d07
Fix for APCu cache otherwise you get 'Cache key must be string, "boolean" given'
...
Also corrects parameter variable name
2017-03-03 10:35:01 +00:00
58f336928a
Merge pull request #6672 from andrewandante/FIX/apcu-cache-error
...
FIX/apcu cache errors
2017-03-03 15:37:50 +13:00
abe967f235
FIX/pass arguments directly (not in array)
2017-03-02 11:12:06 +00:00
b6d9b34ce4
BUG Mark $instance as internal to prevent being saved to config
2017-03-02 17:19:44 +13:00
6ed98a3a94
BUG Prevent obsolete class cache breaking autoload
...
Remove hard-coded class paths
2017-03-01 10:06:15 +13:00
3983b4d1b1
Fix cache used in ModuleManifest
2017-02-27 16:54:01 +13:00
c452d5f6cd
API Rename CoreConfigCreator to CoreConfigFactory
...
Fix rebase regressions
2017-02-27 16:54:01 +13:00
a6e9a7111b
API Substitute core config system with new silverstripe/config module
2017-02-27 16:54:01 +13:00
72ddac2a56
API Implement ModuleLoader for module registration by composer name
2017-02-27 16:54:01 +13:00
d220ca3f67
API Use symfony/cache ( fixes #6252 )
2017-02-26 13:07:59 +13:00
7156da6279
Merge branch '3'
2017-02-20 22:19:33 +00:00
029a8b9586
API Substitute Zend_Currency with NumberFormatter based solution
...
API Substitute Zend_Locale with Locale / NumberFormatter
API Substitute Zend_Date with IntlDateFormatter
API Added DBTIme::Nice12, FormatFromSettings
API Added Short() method to DBDate / DBTime / DBDatetime
API Add Date::getTimestamp()
API Added setSubmittedValue api for FormField
API Add second arg to base FormField::setValue()
API Major refactor of i18n into component data parts
API Implement Resettable interface to reset objects between tests
ENHANCEMENT Changed DBField::create_field return type to `static` to support better type hinting
ENHANCEMENT i18nTextCollector supports __CLASS__
2017-02-09 15:28:59 +13:00
8c8231c03e
NEW Director::host() to determine host name of site
2017-01-31 21:36:04 +00:00
873fd8c5bc
NEW replace _ss_environment.php with .env and environment vars
2017-01-31 20:40:17 +00:00
a5da085cc7
Merge branch '3'
2017-01-31 17:03:53 +00:00
232b218dfb
FIX Ensure that Zend_ classes can still be autoloaded
2017-01-30 11:12:24 +13:00
de02a3f733
Restored context parameter to i18n, and added to a “comment” key
...
Rolled pluralisation functionality into the i18n::_t() method
Warnings on missing default can now be turned off
2017-01-25 18:12:40 +13:00
8a07c56bdf
API Replace i18n message localisation with symfony/translation
...
API Implement enhanced pluralisation
Remove Zend_Translate and all Zend dependencies from i18n
Deprecated $context from i18n::_t()
Warn on missing default string for i18n::_t()
2017-01-25 17:08:12 +13:00
8b4cce435e
Merge branch '3'
2017-01-17 14:17:45 +00:00
ba39e552a2
Merge branch '3'
2016-12-15 12:20:29 +00:00
085c8f5a43
ENHANCEMENT 2x increase in scanning of files for ConfigManifest
2016-12-08 21:35:38 +11:00
4b7d31377b
PSR2: Automatic fixes
2016-11-29 12:33:28 +13:00
1b1e921e3d
PSR2: Whitespace-only changes
2016-11-29 12:31:16 +13:00
1be2e70a2a
Merge branch '3'
2016-11-24 14:18:09 +00:00
06d1297fbe
Replace hard-coded directory separators constant
...
This removes warnings when building the manifest cache in Windows environments.
2016-11-24 08:05:56 +13:00
6e8304ff2f
API Namespace framework tests
2016-11-23 19:25:12 +13:00
f18ef75c3d
BUGFIX: Fixed crash when BASE_PATH is set by assuming the location of Constants.php
2016-11-04 13:43:42 -03:00
5650254b53
NEW: Fixes to allow code files in src/ folder.
...
Separated from the file renames for clarity.
2016-11-01 16:35:32 +13:00
e9d2f2f733
NEW: Use composer autoloader to set the right include path.
2016-11-01 16:35:02 +13:00
7a10c194bd
NEW: Move code files into src/ folder.
...
This updates framework to be more in keeping with PHP conventions.
2016-11-01 13:37:24 +13:00
Daniel Hensby
Damian Mooyman
Robbie Averill
Christopher Joe
Aaron Carlino
zanderwar
Daniel Hensby
Raissa North
Andrew Aitken-Fincham
Sam Minnee
Loz Calver
Chris Joe
Loz Calver
Ingo Schommer
Daniel Hensby
Will Rossiter
Franco Springveldt
Christopher Joe
Ingo Schommer
Daniel Hensby
Lee Bradley
Jake Bentvelzen
Christopher Pitt
UndefinedOffset