tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

BUG Fixed dropdown step definition for "preview" dropdowns

Browse Source 
Broke after I optimized it to work with a TreeDropdownField
which assumes <li><a> structures that thie "preview" dropdowns
don't have. I also failed at the recursion assignment, causing
infinite loops...
This commit is contained in:
Ingo Schommer 2013-06-07 11:45:09 +02:00
parent 59fb88bec7
commit ff5624c57e
1 changed files with 33 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
tests/behat/features/bootstrap/SilverStripe/Framework/Test/Behaviour/CmsUiContext.php
View File

@ -9,7 +9,8 @@ use Behat\Behat\Context\ClosuredContextInterface,
Behat\Behat\Exception\PendingException, Behat\Behat\Exception\PendingException,
Behat\Mink\Exception\ElementNotFoundException, Behat\Mink\Exception\ElementNotFoundException,
Behat\Gherkin\Node\PyStringNode, Behat\Gherkin\Node\PyStringNode,
Behat\Gherkin\Node\TableNode; Behat\Gherkin\Node\TableNode,
Behat\Mink\Element\NodeElement;
// PHPUnit // PHPUnit
@ -355,31 +356,21 @@ class CmsUiContext extends BehatContext
)); ));
// Traverse up to field holder // Traverse up to field holder
$containers = array(); $container = null;
foreach($formFields as $formField) { foreach($formFields as $formField) {
do { $container = $this->findParentByClass($formField, 'field');
$container = $formField->getParent(); if($container) break; // Default to first visible container
$containerClasses = explode(' ', $container->getAttribute('class'));
$containers[] = $container;
} while(
$container
&& in_array('field', $containerClasses)
&& $container->getTagName() != 'form'
);
} }
assertGreaterThan(0, count($containers), 'Chosen.js field container not found'); assertNotNull($container, 'Chosen.js field container not found');
// Default to first visible container
$container = $containers[0];
// Click on newly expanded list element, indirectly setting the dropdown value // Click on newly expanded list element, indirectly setting the dropdown value
$linkEl = $container->find('xpath', './/a[./@href]'); $linkEl = $container->find('xpath', './/a[./@href]');
assertNotNull($linkEl, 'Chosen.js link element not found'); assertNotNull($linkEl, 'Chosen.js link element not found');
$this->getSession()->wait(100); // wait for dropdown overlay to appear $this->getSession()->wait(100); // wait for dropdown overlay to appear
$linkEl->click(); $linkEl->click();
if(in_array('treedropdown', $containerClasses)) { if(in_array('treedropdown', explode(' ', $container->getAttribute('class')))) {
// wait for ajax dropdown to load // wait for ajax dropdown to load
$this->getSession()->wait( $this->getSession()->wait(
5000, 5000,
@ -390,7 +381,6 @@ class CmsUiContext extends BehatContext
$this->getSession()->wait(300); $this->getSession()->wait(300);
} }
$listEl = $container->find('xpath', sprintf('.//li[contains(normalize-space(string(.)), \'%s\')]', $value)); $listEl = $container->find('xpath', sprintf('.//li[contains(normalize-space(string(.)), \'%s\')]', $value));
if(null === $listEl) { if(null === $listEl) {
throw new \InvalidArgumentException(sprintf( throw new \InvalidArgumentException(sprintf(
@ -399,7 +389,12 @@ class CmsUiContext extends BehatContext
)); ));
} }
$listEl->find('xpath', './/a')->click(); $listLinkEl = $listEl->find('xpath', './/a');
if($listLinkEl) {
$listLinkEl->click();
} else {
$listEl->click();
}
} }
/** /**
@ -413,4 +408,24 @@ class CmsUiContext extends BehatContext
{ {
return str_replace('\\"', '"', $argument); return str_replace('\\"', '"', $argument);
} }
/**
* Returns the closest parent element having a specific class attribute.
*
* @param NodeElement $el
* @param String $class
* @return Element|null
*/
protected function findParentByClass(NodeElement $el, $class) {
$container = $el->getParent();
while($container && $container->getTagName() != 'body'
) {
if($container->isVisible() && in_array($class, explode(' ', $container->getAttribute('class')))) {
return $container;
}
$container = $container->getParent();
}
return null;
}
} }