tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

NEW: Pre-populate and disable foreign key field on has many lists.

Browse Source 
This is a common use case, and by default a form field is added which
has no effect. While this coupling is undesirable, it makes the default
behaviour much more sensible.

See #2662, #2651, #2637 for more information.
This commit is contained in:
Andrew Short 2013-11-13 16:21:18 +11:00
parent 7ace631499
commit fc773c5c22
2 changed files with 43 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
forms/gridfield/GridFieldDetailForm.php
View File

@ -372,8 +372,26 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler {
$actions->push(new LiteralField('cancelbutton', $text)); $actions->push(new LiteralField('cancelbutton', $text));
} }
} }
$fields = $this->component->getFields(); $fields = $this->component->getFields();
if(!$fields) $fields = $this->record->getCMSFields(); if(!$fields) $fields = $this->record->getCMSFields();
// If we are creating a new record in a has-many list, then
// pre-populate the record's foreign key. Also disable the form field as
// it has no effect.
if($list instanceof HasManyList) {
$key = $list->getForeignKey();
$id = $list->getForeignID();
if(!$this->record->isInDB()) {
$this->record->$key = $id;
}
if($field = $fields->dataFieldByName($key)) {
$fields->makeFieldReadonly($field);
}
}
$form = new Form( $form = new Form(
$this, $this,
'ItemEditForm', 'ItemEditForm',

25
tests/forms/gridfield/GridFieldDetailFormTest.php
View File

@ -220,6 +220,31 @@ class GridFieldDetailFormTest extends FunctionalTest {
$form = $request->ItemEditForm(); $form = $request->ItemEditForm();
$this->assertNotNull($form->Fields()->fieldByName('Callback')); $this->assertNotNull($form->Fields()->fieldByName('Callback'));
} }
/**
* Tests that a has-many detail form is pre-populated with the parent ID.
*/
public function testHasManyFormPrePopulated() {
$group = $this->objFromFixture(
'GridFieldDetailFormTest_PeopleGroup', 'group'
);
$this->logInWithPermission('ADMIN');
$response = $this->get('GridFieldDetailFormTest_Controller');
$parser = new CSSContentParser($response->getBody());
$addLink = $parser->getBySelector('.ss-gridfield .new-link');
$addLink = (string) $addLink[0]['href'];
$response = $this->get($addLink);
$parser = new CSSContentParser($response->getBody());
$title = $parser->getBySelector('#GroupID span');
$id = $parser->getBySelector('#GroupID input');
$this->assertEquals($group->Name, (string) $title[0]);
$this->assertEquals($group->ID, (string) $id[0]['value']);
}
} }
class GridFieldDetailFormTest_Person extends DataObject implements TestOnly { class GridFieldDetailFormTest_Person extends DataObject implements TestOnly {