tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

BUGFIX Database::doesSchemaNeedUpdating() if schemaUpdateTransaction is NULL, then return FALSE. If schemaUpdateTransaction is an array, then return TRUE. This replaces the automatic casting which is not clear.

Browse Source
This commit is contained in:
Sean Harvey 2012-05-10 13:58:29 +12:00
parent 7dcfdb05fa
commit f30a3bd760
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
model/Database.php
View File

@ -230,9 +230,9 @@ abstract class SS_Database {
* Returns true if schema modifications were requested after a beginSchemaUpdate() call. * Returns true if schema modifications were requested after a beginSchemaUpdate() call.
*/ */
function doesSchemaNeedUpdating() { function doesSchemaNeedUpdating() {
return (bool)$this->schemaUpdateTransaction; return ($this->schemaUpdateTransaction === null) ? false : true;
} }
// Transactional schema altering functions - they don't do anyhting except for update schemaUpdateTransaction // Transactional schema altering functions - they don't do anyhting except for update schemaUpdateTransaction
/** /**