From f30277c3cf27c887b607a2337d4281d70c548a0e Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Thu, 10 Jan 2013 23:32:13 +0100
Subject: [PATCH] Split out getLinkAttributes() in .htmleditor JavaScript for
 more flexibility

Saves us from overwriting the whole insertLink() method just
to add another option.
---
 javascript/HtmlEditorField.js | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/javascript/HtmlEditorField.js b/javascript/HtmlEditorField.js
index dc295ba4e..5c2e505a2 100644
--- a/javascript/HtmlEditorField.js
+++ b/javascript/HtmlEditorField.js
@@ -520,7 +520,10 @@ ss.editorWrappers['default'] = ss.editorWrappers.tinyMCE;
 					this.find('.field#AnchorRefresh').show();
 				}
 			},
-			insertLink: function() {
+			/**
+			 * @return Object Keys: 'href', 'target', 'title'
+			 */
+			getLinkAttributes: function() {
 				var href, target = null, anchor = this.find(':input[name=Anchor]').val();
 				
 				// Determine target
@@ -555,22 +558,22 @@ ss.editorWrappers['default'] = ss.editorWrappers.tinyMCE;
 						break;
 				}
 
-				var attributes = {
+				return {
 					href : href, 
 					target : target, 
 					title : this.find(':input[name=Description]').val()
 				};
-
+			},
+			insertLink: function() {
 				this.modifySelection(function(ed){
-					ed.insertLink(attributes);
-				})
-
+					ed.insertLink(this.getLinkAttributes());
+				});
 				this.updateFromEditor();
 			},
 			removeLink: function() {
 				this.modifySelection(function(ed){
 					ed.removeLink();
-				})
+				});
 				this.close();
 			},
 			addAnchorSelector: function() {