mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-09-30 13:19:11 +02:00
FIX getComponentByType can return null - prevent null pointer errors
This commit is contained in:
parent
1f1c344272
commit
f22a4b980b
@ -284,9 +284,10 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
|
|||||||
$previousAndNextGroup->addExtraClass('circular-group mr-2');
|
$previousAndNextGroup->addExtraClass('circular-group mr-2');
|
||||||
$previousAndNextGroup->setFieldHolderTemplate(get_class($previousAndNextGroup) . '_holder_buttongroup');
|
$previousAndNextGroup->setFieldHolderTemplate(get_class($previousAndNextGroup) . '_holder_buttongroup');
|
||||||
|
|
||||||
|
/** @var GridFieldDetailForm $component */
|
||||||
$component = $this->gridField->getConfig()->getComponentByType(GridFieldDetailForm::class);
|
$component = $this->gridField->getConfig()->getComponentByType(GridFieldDetailForm::class);
|
||||||
$gridState = $this->getRequest()->requestVar('gridState');
|
$gridState = $this->getRequest()->requestVar('gridState');
|
||||||
if ($component->getShowPagination()) {
|
if ($component && $component->getShowPagination()) {
|
||||||
$previousAndNextGroup->push(FormAction::create('doPrevious')
|
$previousAndNextGroup->push(FormAction::create('doPrevious')
|
||||||
->setUseButtonTag(true)
|
->setUseButtonTag(true)
|
||||||
->setAttribute('data-grid-state', $gridState)
|
->setAttribute('data-grid-state', $gridState)
|
||||||
@ -302,7 +303,7 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
|
|||||||
|
|
||||||
$rightGroup->push($previousAndNextGroup);
|
$rightGroup->push($previousAndNextGroup);
|
||||||
|
|
||||||
if ($component->getShowAdd()) {
|
if ($component && $component->getShowAdd()) {
|
||||||
$rightGroup->push(FormAction::create('doNew')
|
$rightGroup->push(FormAction::create('doNew')
|
||||||
->setUseButtonTag(true)
|
->setUseButtonTag(true)
|
||||||
->setAttribute('data-grid-state', $this->getRequest()->getVar('gridState'))
|
->setAttribute('data-grid-state', $this->getRequest()->getVar('gridState'))
|
||||||
|
Loading…
Reference in New Issue
Block a user