tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

FIX Exists statements can't remove GROUP BY if there's a HAVING clause as it might rely on an aggregate

Browse Source
This commit is contained in:
Guy Marriott 2019-04-17 09:49:46 +12:00 committed by Sam Minnee
parent 91591373d6
commit ef0af7ae9c
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ORM/DataQuery.php
View File

@ -466,12 +466,17 @@ class DataQuery
$statement = $this->getFinalisedQuery(); $statement = $this->getFinalisedQuery();
$statement->setSelect('*'); $statement->setSelect('*');
// Clear limit, distinct, grouping, and order as it's not relevant for an exists query // Clear limit, distinct, and order as it's not relevant for an exists query
$statement->setDistinct(false); $statement->setDistinct(false);
$statement->setOrderBy(null); $statement->setOrderBy(null);
$statement->setGroupBy(null);
$statement->setLimit(null); $statement->setLimit(null);
// We can remove grouping if there's no "having" that might be relying on an aggregate
$having = $statement->getHaving();
if (empty($having)) {
$statement->setGroupBy(null);
}
// Wrap the whole thing in an "EXISTS" // Wrap the whole thing in an "EXISTS"
$sql = 'SELECT EXISTS(' . $statement->sql($params) . ')'; $sql = 'SELECT EXISTS(' . $statement->sql($params) . ')';
$result = DB::prepared_query($sql, $params); $result = DB::prepared_query($sql, $params);