tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #9315 from creative-commoners/pulls/4/fix-alt-text-in-tests

Browse Source 
FIX Adjust HTMLEditorField tests to support alt attr changes in assets
This commit is contained in:
Serge Latyntsev 2019-11-15 08:24:22 +13:00 committed by GitHub
commit eef1e2b6a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/php/Forms/HTMLEditor/HTMLEditorFieldTest.php
View File

@ -122,9 +122,9 @@ class HTMLEditorFieldTest extends FunctionalTest
$parser = new CSSContentParser($obj->dbObject('Content')->forTemplate()); $parser = new CSSContentParser($obj->dbObject('Content')->forTemplate());
$xml = $parser->getByXpath('//img'); $xml = $parser->getByXpath('//img');
$this->assertEquals( $this->assertEquals(
'example', '',
(string)$xml[0]['alt'], (string)$xml[0]['alt'],
'Alt tags are added by default based on filename' 'Alt attribute is always present, even if empty'
); );
$this->assertEquals('', (string)$xml[0]['title'], 'Title tags are added by default.'); $this->assertEquals('', (string)$xml[0]['title'], 'Title tags are added by default.');
$this->assertEquals(10, (int)$xml[0]['width'], 'Width tag of resized image is set.'); $this->assertEquals(10, (int)$xml[0]['width'], 'Width tag of resized image is set.');
@ -180,7 +180,7 @@ class HTMLEditorFieldTest extends FunctionalTest
$this->assertEquals( $this->assertEquals(
<<<EOS <<<EOS
<span class="readonly typography" id="Content"> <span class="readonly typography" id="Content">
<img src="/assets/HTMLEditorFieldTest/f5c7c2f814/example__ResizedImageWzEwLDIwXQ.jpg" alt="example" width="10" height="20"> <img src="/assets/HTMLEditorFieldTest/f5c7c2f814/example__ResizedImageWzEwLDIwXQ.jpg" alt="" width="10" height="20">
</span> </span>
@ -197,7 +197,7 @@ EOS
$this->assertEquals( $this->assertEquals(
<<<EOS <<<EOS
<span class="readonly typography" id="Content"> <span class="readonly typography" id="Content">
<img src="/assets/HTMLEditorFieldTest/f5c7c2f814/example__ResizedImageWzEwLDIwXQ.jpg" alt="example" width="10" height="20"> <img src="/assets/HTMLEditorFieldTest/f5c7c2f814/example__ResizedImageWzEwLDIwXQ.jpg" alt="" width="10" height="20">
</span> </span>
<input type="hidden" name="Content" value="[image src=&quot;/assets/HTMLEditorFieldTest/f5c7c2f814/example.jpg&quot; width=&quot;10&quot; height=&quot;20&quot; id=&quot;{$fileID}&quot;]" /> <input type="hidden" name="Content" value="[image src=&quot;/assets/HTMLEditorFieldTest/f5c7c2f814/example.jpg&quot; width=&quot;10&quot; height=&quot;20&quot; id=&quot;{$fileID}&quot;]" />