tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

ENHANCEMENT: Improving Cookie class to allow for extendability

Browse Source 
Previous to this the Cookie class has been very inflexible (cookies are
all set using the static Cookie::set() and so the functionality is not
extendable). Cookie class has been adjusted so extension is now a
possibility for those wishing to alter its functionality. Improves
compliance to the law of demeter.
This commit is contained in:
Matt Lewis 2012-06-29 17:32:47 +01:00
parent 976f1f5da0
commit ebb2458f22
1 changed files with 50 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
control/Cookie.php
View File

@ -12,6 +12,20 @@ class Cookie {
*/
static $report_errors = true;
/**
* Cookie class and instance for extendability purposes
*/
static $cookie_class = 'Cookie';
static $inst = null;
public static function get_inst() {
if(is_null(self::$inst)) {
self::$inst = new self::$cookie_class();
}
return self::$inst;
}
/**
* Set a cookie variable
*
@ -24,6 +38,29 @@ class Cookie {
* @param boolean $httpOnly See http://php.net/set_session
*/
static function set($name, $value, $expiry = 90, $path = null, $domain = null, $secure = false, $httpOnly = false) {
return self::get_inst()->inst_set($name, $value, $expiry, $path, $domain, $secure, $httpOnly);
}
/**
* Get a cookie variable
*/
static function get($name) {
return self::get_inst()->inst_get($name);
}
static function forceExpiry($name, $path = null, $domain = null) {
return self::get_inst()->inst_forceExpiry($name, $path, $domain);
}
static function set_report_errors($reportErrors) {
return self::get_inst()->inst_set_report_errors($reportErrors);
}
static function report_errors() {
return self::get_inst()->inst_report_errors();
}
public function inst_set($name, $value, $expiry = 90, $path = null, $domain = null, $secure = false, $httpOnly = false) {
if(!headers_sent($file, $line)) {
$expiry = $expiry > 0 ? time()+(86400*$expiry) : $expiry;
$path = ($path) ? $path : Director::baseURL();
@ -35,24 +72,21 @@ class Cookie {
}
}
/**
* Get a cookie variable
*/
static function get($name) {
public function inst_get($name) {
return isset($_COOKIE[$name]) ? $_COOKIE[$name] : null;
}
static function forceExpiry($name, $path = null, $domain = null) {
public function inst_forceExpiry($name, $path = null, $domain = null) {
if(!headers_sent($file, $line)) {
self::set($name, null, -20, $path, $domain);
}
}
static function set_report_errors($reportErrors) {
public function inst_set_report_errors($reportErrors) {
self::$report_errors = $reportErrors;
}
static function report_errors() {
public function report_errors() {
return self::$report_errors;
}
}