tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-01 13:48:37 +02:00
Code Issues Projects Releases Wiki Activity

Use ::create instead of new in GridFieldDetailForm_ItemRequest (#10791)

Browse Source 
Updates instances of `new X` to `X::create` so that Silverstripe classes will respect dependency injection
This commit is contained in:
Bernard Hamlin 2023-05-25 11:42:43 +12:00 committed by GitHub
parent e8bde0f4f5
commit e98f0d45af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Forms/GridField/GridFieldDetailForm_ItemRequest.php
View File

@ -137,7 +137,7 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
$form = $this->ItemEditForm();
$form->makeReadonly();
$data = new ArrayData([
$data = ArrayData::create([
'Backlink' => $controller->Link(),
'ItemEditForm' => $form
]);
@ -235,7 +235,7 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
}
}
$form = new Form(
$form = Form::create(
$this,
'ItemEditForm',
$fields,
@ -434,7 +434,7 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
$oneLevelUp->Link, // url
_t('SilverStripe\\Forms\\GridField\\GridFieldDetailForm.CancelBtn', 'Cancel') // label
);
$actions->insertAfter('MajorActions', new LiteralField('cancelbutton', $text));
$actions->insertAfter('MajorActions', LiteralField::create('cancelbutton', $text));
}
}
@ -879,17 +879,17 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
$items = $this->popupController->Breadcrumbs($unlinked);
if (!$items) {
$items = new ArrayList();
$items = ArrayList::create();
}
if ($this->record && $this->record->ID) {
$title = ($this->record->Title) ? $this->record->Title : "#{$this->record->ID}";
$items->push(new ArrayData([
$items->push(ArrayData::create([
'Title' => $title,
'Link' => $this->Link()
]));
} else {
$items->push(new ArrayData([
$items->push(ArrayData::create([
'Title' => _t('SilverStripe\\Forms\\GridField\\GridField.NewRecord', 'New {type}', ['type' => $this->record->i18n_singular_name()]),
'Link' => false
]));