tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

BUG Remove html5 number field due to insufficient localisation support

Browse Source
This commit is contained in:
Damian Mooyman 2015-09-01 11:05:58 +12:00
parent 3f181d1ce1
commit e86b45bf5d
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
forms/NumericField.php
View File

@ -82,13 +82,6 @@ class NumericField extends TextField {
return 'numeric text'; return 'numeric text';
} }
public function getAttributes() {
return array_merge(parent::getAttributes(), array(
'type' => 'number',
'step' => 'any' // allows entering float/decimal numbers like "1.2" instead of just integers
));
}
/** /**
* Validate this field * Validate this field
* *

6
tests/forms/NumericFieldTest.php
View File

@ -187,8 +187,10 @@ class NumericFieldTest extends SapphireTest {
$field = new NumericField('Number'); $field = new NumericField('Number');
$html = $field->Field(); $html = $field->Field();
$this->assertContains('type="number"', $html, 'number type set');
$this->assertContains('step="any"', $html, 'step value set to any'); // @todo - Revert to number one day when html5 number supports proper localisation
// See https://github.com/silverstripe/silverstripe-framework/pull/4565
$this->assertContains('type="text"', $html, 'number type not set');
} }
} }