tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Clarify DataObject::__construct()

Browse Source 
The $record argument should NOT be used for object construction, since it bypasses setters.
While the original PHPDoc hints at this (“internal systems”), it doesn’t make it clear enough.
This commit is contained in:
Ingo Schommer 2017-01-09 16:50:40 +13:00
parent 3e32b18c6b
commit e55554d087
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
model/DataObject.php
View File

@ -425,8 +425,9 @@ class DataObject extends ViewableData implements DataObjectInterface, i18nEntity
/** /**
* Construct a new DataObject. * Construct a new DataObject.
* *
* @param array|null $record This will be null for a new database record. Alternatively, you can pass an array of * @param array|null $record Used internally for rehydrating an object from database content.
* field values. Normally this contructor is only used by the internal systems that get objects from the database. * Bypasses setters on this class, and hence should not be used
* for populating data on new records.
* @param boolean $isSingleton This this to true if this is a singleton() object, a stub for calling methods. * @param boolean $isSingleton This this to true if this is a singleton() object, a stub for calling methods.
* Singletons don't have their defaults set. * Singletons don't have their defaults set.
*/ */