tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #9627 from creative-commoners/pulls/4.6/try-catch-config-db-paths

Browse Source 
FIX Handle DatabaseAdapterRegistry cache exception
This commit is contained in:
Loz Calver 2020-08-03 09:19:02 +01:00 committed by GitHub
commit e368c370ff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/Dev/Install/DatabaseAdapterRegistry.php
View File

@ -164,9 +164,17 @@ class DatabaseAdapterRegistry implements Flushable
if (isset($_GET['flush'])) { if (isset($_GET['flush'])) {
static::flush(); static::flush();
} }
$cache = static::getCache(); try {
$cache = static::getCache();
} catch (\LogicException $e) {
// This try/catch statement is here rather than in getCache() for semver
// A LogicException may be thrown from `Symfony\Component\Finder\Finder::getIterator()`
// if the config manifest is empty. There are some edge cases where this can happen, for instance
// running `sspak save` on a fresh install without ?flush
$cache = null;
}
$key = __FUNCTION__; $key = __FUNCTION__;
if ($cache->has($key)) { if ($cache && $cache->has($key)) {
return (array) $cache->get($key); return (array) $cache->get($key);
} else { } else {
try { try {
@ -174,11 +182,16 @@ class DatabaseAdapterRegistry implements Flushable
} catch (Exception $e) { } catch (Exception $e) {
$paths = []; $paths = [];
} }
$cache->set($key, $paths); if ($cache) {
$cache->set($key, $paths);
}
return $paths; return $paths;
} }
} }
/**
* @return CacheInterface
*/
public static function getCache(): CacheInterface public static function getCache(): CacheInterface
{ {
return Injector::inst()->get(CacheInterface::class . '.DatabaseAdapterRegistry'); return Injector::inst()->get(CacheInterface::class . '.DatabaseAdapterRegistry');