tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

MNT Don't change auto-increment for non mysql database in test (#10906)

Browse Source
This commit is contained in:
Guy Sartorelli 2023-08-08 14:43:25 +12:00 committed by GitHub
parent f345646481
commit e29be44373
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/php/ORM/DataListEagerLoadingTest.php
View File

@ -5,6 +5,7 @@ namespace SilverStripe\ORM\Tests;
use InvalidArgumentException;
use LogicException;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\Connect\MySQLDatabase;
use SilverStripe\ORM\DataList;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\DB;
@ -78,6 +79,15 @@ class DataListEagerLoadingTest extends SapphireTest
public static function setUpBeforeClass(): void
{
parent::setUpBeforeClass();
// The AUTO_INCREMENT functionality isn't abstracted, and doesn't work with the same syntax in
// other database drivers. But for other drivers we don't care so much if there are overlapping
// IDs because avoiding them is only required to test the PHP logic, not the database driver
// compatibility.
if (!(DB::get_conn() instanceof MySQLDatabase)) {
return;
}
// Set non-zero auto increment offset for each object type so we don't end up with the same IDs across
// the board. If all of the IDs are 0, 1, 2 then we have no way of knowing if we're accidentally mixing
// up relation ID lists between different relation lists for different classes.