tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Remove usage of asserts with strings

Browse Source
This commit is contained in:
Daniel Hensby 2017-11-30 18:11:59 +00:00
parent 9103816333
commit e23fcda6b6
No known key found for this signature in database
GPG Key ID: B00D1E9767F0B06E
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
core/Diff.php
View File

@ -413,7 +413,7 @@ class _DiffEngine
$i = 0; $i = 0;
$j = 0; $j = 0;
USE_ASSERTS && assert('sizeof($lines) == sizeof($changed)'); USE_ASSERTS && assert(sizeof($lines) == sizeof($changed));
$len = sizeof($lines); $len = sizeof($lines);
$other_len = sizeof($other_changed); $other_len = sizeof($other_changed);
@ -433,7 +433,7 @@ class _DiffEngine
$j++; $j++;
while ($i < $len && ! $changed[$i]) { while ($i < $len && ! $changed[$i]) {
USE_ASSERTS && assert('$j < $other_len && ! $other_changed[$j]'); USE_ASSERTS && assert($j < $other_len && ! $other_changed[$j]);
$i++; $j++; $i++; $j++;
while ($j < $other_len && $other_changed[$j]) while ($j < $other_len && $other_changed[$j])
$j++; $j++;
@ -465,10 +465,10 @@ class _DiffEngine
$changed[--$i] = false; $changed[--$i] = false;
while ($start > 0 && $changed[$start - 1]) while ($start > 0 && $changed[$start - 1])
$start--; $start--;
USE_ASSERTS && assert('$j > 0'); USE_ASSERTS && assert($j > 0);
while ($other_changed[--$j]) while ($other_changed[--$j])
continue; continue;
USE_ASSERTS && assert('$j >= 0 && !$other_changed[$j]'); USE_ASSERTS && assert($j >= 0 && !$other_changed[$j]);
} }
/* /*
@ -491,7 +491,7 @@ class _DiffEngine
while ($i < $len && $changed[$i]) while ($i < $len && $changed[$i])
$i++; $i++;
USE_ASSERTS && assert('$j < $other_len && ! $other_changed[$j]'); USE_ASSERTS && assert($j < $other_len && ! $other_changed[$j]);
$j++; $j++;
if ($j < $other_len && $other_changed[$j]) { if ($j < $other_len && $other_changed[$j]) {
$corresponding = $i; $corresponding = $i;
@ -508,10 +508,10 @@ class _DiffEngine
while ($corresponding < $i) { while ($corresponding < $i) {
$changed[--$start] = 1; $changed[--$start] = 1;
$changed[--$i] = 0; $changed[--$i] = 0;
USE_ASSERTS && assert('$j > 0'); USE_ASSERTS && assert($j > 0);
while ($other_changed[--$j]) while ($other_changed[--$j])
continue; continue;
USE_ASSERTS && assert('$j >= 0 && !$other_changed[$j]'); USE_ASSERTS && assert($j >= 0 && !$other_changed[$j]);
} }
} }
} }