tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

NEW Allow GridFieldConfig::addComponents to accept an array (#7844)

Browse Source
This commit is contained in:
Robbie Averill 2018-02-08 11:06:27 +13:00 committed by Damian Mooyman
parent e0e8ca0ee6
commit dd82820242
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Forms/GridField/GridFieldConfig.php
View File

@ -68,12 +68,12 @@ class GridFieldConfig
} }
/** /**
* @param GridFieldComponent $component,... One or more components * @param GridFieldComponent|GridFieldComponent[] $component,... One or more components, or an array of components
* @return $this * @return $this
*/ */
public function addComponents($component = null) public function addComponents($component = null)
{ {
$components = func_get_args(); $components = is_array($component) ? $component : func_get_args();
foreach ($components as $component) { foreach ($components as $component) {
$this->addComponent($component); $this->addComponent($component);
} }

13
tests/php/Forms/GridField/GridFieldConfigTest.php
View File

@ -92,6 +92,19 @@ class GridFieldConfigTest extends SapphireTest
); );
} }
public function testAddComponentsByArray()
{
$config = GridFieldConfig::create()
->addComponents([
$c1 = new MyComponent(),
]);
$this->assertEquals(
$c1,
$config->getComponentByType(MyComponent::class)
);
}
public function testRemoveComponents() public function testRemoveComponents()
{ {
$config = GridFieldConfig::create() $config = GridFieldConfig::create()