From 4385264aa9da453d3a9fcf28d92c61ef31d928f2 Mon Sep 17 00:00:00 2001
From: unclecheese <unclecheese@leftandmain.com>
Date: Thu, 8 Aug 2013 17:12:40 +1200
Subject: [PATCH] API Change: Make GridFieldConfig objects decoratable

This change promotes GridFieldConfig objects to first-class Object descendants, making them extendable through the decorator pattern.

Relevant discussion in the dev group: https://groups.google.com/forum/#!topic/silverstripe-dev/Z6tu1k05ZmA
---
 forms/gridfield/GridFieldConfig.php | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/forms/gridfield/GridFieldConfig.php b/forms/gridfield/GridFieldConfig.php
index 78895d542..fcf6b55fd 100644
--- a/forms/gridfield/GridFieldConfig.php
+++ b/forms/gridfield/GridFieldConfig.php
@@ -19,28 +19,19 @@
  * @package framework
  * @subpackage fields-gridfield
  */
-class GridFieldConfig {
+class GridFieldConfig extends Object {
 
 	/**
 	 * @var ArrayList
 	 */
 	protected $components = null;
 	
-	/**
-	 * @param mixed $arguments,... arguments to pass to the constructor
-	 * @return GridFieldConfig
-	 */
-	public static function create() {
-		return call_user_func_array('Object::create', array_merge(
-			array(get_called_class()), 
-			func_get_args()
-		));
-	}
 	
 	/**
 	 * 
 	 */
 	public function __construct() {
+		parent::__construct();
 		$this->components = new ArrayList();
 	}
 	
@@ -147,6 +138,7 @@ class GridFieldConfig_Base extends GridFieldConfig {
 	 * @param int $itemsPerPage - How many items per page should show up
 	 */
 	public function __construct($itemsPerPage=null) {
+		parent::__construct();
 		$this->addComponent(new GridFieldToolbarHeader());
 		$this->addComponent($sort = new GridFieldSortableHeader());
 		$this->addComponent($filter = new GridFieldFilterHeader());
@@ -157,6 +149,8 @@ class GridFieldConfig_Base extends GridFieldConfig {
 		$sort->setThrowExceptionOnBadDataType(false);
 		$filter->setThrowExceptionOnBadDataType(false);
 		$pagination->setThrowExceptionOnBadDataType(false);
+
+		$this->extend('updateConfig');
 	}
 }
 
@@ -173,6 +167,8 @@ class GridFieldConfig_RecordViewer extends GridFieldConfig_Base {
 
 		$this->addComponent(new GridFieldViewButton());
 		$this->addComponent(new GridFieldDetailForm());
+
+		$this->extend('updateConfig');
 	}
 
 }
@@ -187,6 +183,7 @@ class GridFieldConfig_RecordEditor extends GridFieldConfig {
 	 * @param int $itemsPerPage - How many items per page should show up
 	 */
 	public function __construct($itemsPerPage=null) {
+		parent::__construct();
 		
 		$this->addComponent(new GridFieldButtonRow('before'));
 		$this->addComponent(new GridFieldAddNewButton('buttons-before-left'));
@@ -203,6 +200,8 @@ class GridFieldConfig_RecordEditor extends GridFieldConfig {
 		$sort->setThrowExceptionOnBadDataType(false);
 		$filter->setThrowExceptionOnBadDataType(false);
 		$pagination->setThrowExceptionOnBadDataType(false);
+
+		$this->extend('updateConfig');
 	}
 }
 
@@ -233,6 +232,7 @@ class GridFieldConfig_RelationEditor extends GridFieldConfig {
 	 * @param int $itemsPerPage - How many items per page should show up
 	 */
 	public function __construct($itemsPerPage=null) {
+		parent::__construct();
 		
 		$this->addComponent(new GridFieldButtonRow('before'));
 		$this->addComponent(new GridFieldAddNewButton('buttons-before-left'));
@@ -250,5 +250,7 @@ class GridFieldConfig_RelationEditor extends GridFieldConfig {
 		$sort->setThrowExceptionOnBadDataType(false);
 		$filter->setThrowExceptionOnBadDataType(false);
 		$pagination->setThrowExceptionOnBadDataType(false);
+
+		$this->extend('updateConfig');
 	}
 }