From e9ba54dec71f59c6f77235502cbc3df8e4ae0e71 Mon Sep 17 00:00:00 2001 From: uniun Date: Tue, 15 Jan 2013 11:29:35 +0200 Subject: [PATCH] Impossible to unselect TreeDropdownField It was impossible to unselect TreeDropdownField. '!' operator should not be used at all and identical comparison (===) was too "strict" (self.getValue() returns string but $(node).data('id') returns number). --- javascript/TreeDropdownField.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/TreeDropdownField.js b/javascript/TreeDropdownField.js index a27f19b0a..7eeb01773 100644 --- a/javascript/TreeDropdownField.js +++ b/javascript/TreeDropdownField.js @@ -148,7 +148,7 @@ .jstree(self.getTreeConfig()) .bind('select_node.jstree', function(e, data) { var node = data.rslt.obj, id = $(node).data('id'); - if(!firstLoad && !self.getValue() === id) { + if(!firstLoad && self.getValue() == id) { // Value is already selected, unselect it (for lack of a better UI to do this) self.data('metadata', null); self.setTitle(null);