tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

FIX Postgres booleans should return as int for consistency

Browse Source
This commit is contained in:
Guy Marriott 2019-04-17 15:15:17 +12:00
parent 2c207b636a
commit da1af3d8b0
No known key found for this signature in database
GPG Key ID: A80F9ACCB86D3DA7
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/ORM/Connect/PDOStatementHandle.php
View File

@ -47,6 +47,7 @@ class PDOStatementHandle
'float8' => 'float', 'float8' => 'float',
'float16' => 'float', 'float16' => 'float',
'numeric' => 'float', 'numeric' => 'float',
'bool' => 'int', // Bools should be ints
// MySQL // MySQL
'NEWDECIMAL' => 'float', 'NEWDECIMAL' => 'float',

4
tests/php/ORM/DatabaseTest.php
View File

@ -267,5 +267,9 @@ class DatabaseTest extends SapphireTest
// Dates are returned as strings // Dates are returned as strings
$this->assertInternalType('string', $record['Created'], 'DBDatetime fields should be string (non-prepared)'); $this->assertInternalType('string', $record['Created'], 'DBDatetime fields should be string (non-prepared)');
// Booleans selected directly are ints
$result = DB::query('SELECT TRUE')->first();
$this->assertInternalType('int', reset($result));
} }
} }