tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

FIX: Don't force-add view button to readonly GridField (fixes #9249)

Browse Source
This commit is contained in:
Loz Calver 2019-09-23 16:52:47 +01:00
parent 109ac3f75f
commit d85ff3bc44
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Forms/GridField/GridField.php
View File

@ -247,6 +247,7 @@ class GridField extends FormField
$copy = clone $this; $copy = clone $this;
$copy->setReadonly(true); $copy->setReadonly(true);
$copyConfig = $copy->getConfig(); $copyConfig = $copy->getConfig();
$hadEditButton = $copyConfig->getComponentByType(GridFieldEditButton::class) !== null;
// get the whitelist for allowable readonly components // get the whitelist for allowable readonly components
$allowedComponents = $this->getReadonlyComponents(); $allowedComponents = $this->getReadonlyComponents();
@ -257,8 +258,8 @@ class GridField extends FormField
} }
} }
// As the edit button may have been removed, add a view button if it doesn't have one // If the edit button has been removed, replace it with a view button
if (!$copyConfig->getComponentByType(GridFieldViewButton::class)) { if ($hadEditButton && !$copyConfig->getComponentByType(GridFieldViewButton::class)) {
$copyConfig->addComponent(new GridFieldViewButton); $copyConfig->addComponent(new GridFieldViewButton);
} }