tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

BUGFIX: addFieldToTab segfaulting under PHP 5.2

Browse Source 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105264 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
Mark Stephens 2010-05-20 06:04:30 +00:00 committed by Sam Minnee
parent 56be2afbc5
commit ca873121fa
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
forms/FieldSet.php
View File

@ -335,7 +335,8 @@ class FieldSet extends DataObjectSet {
$i = 0; $i = 0;
foreach($this->items as $child) { foreach($this->items as $child) {
if($name == $child->Name() || $name == $child->id) { if($name == $child->Name() || $name == $child->id) {
array_splice($this->items, $i, 0, array($item)); // On PHP 5.2.6, using $this->items directly in array_splice can segfault
$itms = $this->items; array_splice($itms, $i, 0, array($item));
return $item; return $item;
} elseif($child->isComposite()) { } elseif($child->isComposite()) {
$ret = $child->insertBefore($item, $name); $ret = $child->insertBefore($item, $name);