mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-22 12:05:37 +00:00
Don't flush manifest in test bootstrap for performance reasons
Leave the decision to the phpunit.xml config (via <get> setting), or to the individual run via "phpunit <folder> '' flush=1". Flushing takes multiple seconds even on my fast SSD, which greatly reduces the likelyhood of developers adopting TDD.
This commit is contained in:
parent
9ce0c9a483
commit
c8c84b0935
@ -42,9 +42,6 @@ if(isset($_SERVER['argv'][2])) {
|
||||
$_REQUEST = array_merge($_REQUEST, $_GET);
|
||||
}
|
||||
|
||||
// Always flush the manifest for phpunit test runs
|
||||
$_GET['flush'] = 1;
|
||||
|
||||
// Connect to database
|
||||
require_once $frameworkPath . '/core/Core.php';
|
||||
require_once $frameworkPath . '/tests/FakeController.php';
|
||||
@ -65,4 +62,4 @@ $controller = new FakeController();
|
||||
TestRunner::use_test_manifest();
|
||||
|
||||
// Remove the error handler so that PHPUnit can add its own
|
||||
restore_error_handler();
|
||||
restore_error_handler();
|
Loading…
x
Reference in New Issue
Block a user