ENHANCEMENT Add YamlFixture String argument support

Enhanced YamlFixtureTest to cover this addition.
This commit is contained in:
Michał Ochman 2012-06-29 00:33:00 +02:00
parent 402297ee1f
commit c282190299
2 changed files with 47 additions and 15 deletions

View File

@ -85,17 +85,28 @@ class YamlFixture extends Object {
*/ */
protected $fixtureDictionary; protected $fixtureDictionary;
/**
* String containing fixture
*
* @var String
*/
protected $fixtureString;
/** /**
* @param String Absolute file path, or relative path to {@link Director::baseFolder()} * @param String Absolute file path, or relative path to {@link Director::baseFolder()}
*/ */
function __construct($fixtureFile) { function __construct($fixture) {
if(!Director::is_absolute($fixtureFile)) $fixtureFile = Director::baseFolder().'/'. $fixtureFile; if(false !== strpos($fixture, "\n")) {
$this->fixtureString = $fixture;
} else {
if(!Director::is_absolute($fixture)) $fixture = Director::baseFolder().'/'. $fixture;
if(!file_exists($fixtureFile)) { if(!file_exists($fixture)) {
throw new InvalidArgumentException('YamlFixture::__construct(): Fixture path "' . $fixtureFile . '" not found'); throw new InvalidArgumentException('YamlFixture::__construct(): Fixture path "' . $fixture . '" not found');
} }
$this->fixtureFile = $fixtureFile; $this->fixtureFile = $fixture;
}
parent::__construct(); parent::__construct();
} }
@ -107,6 +118,13 @@ class YamlFixture extends Object {
return $this->fixtureFile; return $this->fixtureFile;
} }
/**
* @return String Fixture string
*/
function getFixtureString() {
return $this->fixtureString;
}
/** /**
* Get the ID of an object from the fixture. * Get the ID of an object from the fixture.
* @param $className The data class, as specified in your fixture file. Parent classes won't work * @param $className The data class, as specified in your fixture file. Parent classes won't work
@ -162,7 +180,11 @@ class YamlFixture extends Object {
DataObject::set_validation_enabled(false); DataObject::set_validation_enabled(false);
$parser = new Spyc(); $parser = new Spyc();
if (isset($this->fixtureString)) {
$fixtureContent = $parser->load($this->fixtureString);
} else {
$fixtureContent = $parser->loadFile($this->fixtureFile); $fixtureContent = $parser->loadFile($this->fixtureFile);
}
$this->fixtureDictionary = array(); $this->fixtureDictionary = array();
foreach($fixtureContent as $dataClass => $items) { foreach($fixtureContent as $dataClass => $items) {

View File

@ -13,12 +13,22 @@ class YamlFixtureTest extends SapphireTest {
$absPath = FRAMEWORK_PATH . '/tests/testing/YamlFixtureTest.yml'; $absPath = FRAMEWORK_PATH . '/tests/testing/YamlFixtureTest.yml';
$obj = new YamlFixture($absPath); $obj = new YamlFixture($absPath);
$this->assertEquals($absPath, $obj->getFixtureFile()); $this->assertEquals($absPath, $obj->getFixtureFile());
$this->assertNull($obj->getFixtureString());
} }
function testRelativeFixturePath() { function testRelativeFixturePath() {
$relPath = FRAMEWORK_DIR . '/tests/testing/YamlFixtureTest.yml'; $relPath = FRAMEWORK_DIR . '/tests/testing/YamlFixtureTest.yml';
$obj = new YamlFixture($relPath); $obj = new YamlFixture($relPath);
$this->assertEquals(Director::baseFolder() . '/' . $relPath, $obj->getFixtureFile()); $this->assertEquals(Director::baseFolder() . '/' . $relPath, $obj->getFixtureFile());
$this->assertNull($obj->getFixtureString());
}
function testStringFixture() {
$absPath = FRAMEWORK_PATH . '/tests/testing/YamlFixtureTest.yml';
$string = file_get_contents($absPath);
$obj = new YamlFixture($string);
$this->assertEquals($string, $obj->getFixtureString());
$this->assertNull($obj->getFixtureFile());
} }
/** /**