From c8c84b0935365745da87b4010743565f4afa5a9b Mon Sep 17 00:00:00 2001 From: Ingo Schommer Date: Thu, 5 Jul 2012 13:33:02 +0200 Subject: [PATCH] Don't flush manifest in test bootstrap for performance reasons Leave the decision to the phpunit.xml config (via setting), or to the individual run via "phpunit '' flush=1". Flushing takes multiple seconds even on my fast SSD, which greatly reduces the likelyhood of developers adopting TDD. --- tests/bootstrap.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/bootstrap.php b/tests/bootstrap.php index 490a1a0c2..89a4c985f 100644 --- a/tests/bootstrap.php +++ b/tests/bootstrap.php @@ -42,9 +42,6 @@ if(isset($_SERVER['argv'][2])) { $_REQUEST = array_merge($_REQUEST, $_GET); } -// Always flush the manifest for phpunit test runs -$_GET['flush'] = 1; - // Connect to database require_once $frameworkPath . '/core/Core.php'; require_once $frameworkPath . '/tests/FakeController.php'; @@ -65,4 +62,4 @@ $controller = new FakeController(); TestRunner::use_test_manifest(); // Remove the error handler so that PHPUnit can add its own -restore_error_handler(); +restore_error_handler(); \ No newline at end of file