tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

BUGFIX #4140 When clicking a tree node that was just dragged, "Stack overflow" error would be given in IE. Firebug would report "Too much recursion" (from r95973)

Browse Source 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102323 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
Ingo Schommer 2010-04-12 00:51:43 +00:00
parent 0375eea256
commit bf57bee1f0
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
javascript/tree/tree.js
View File

@ -724,23 +724,10 @@ DraggableTreeNode.prototype = {
this.aTag._onclick_before_draggable = this.aTag.onclick; this.aTag._onclick_before_draggable = this.aTag.onclick;
this.aTag.baseClick = this.aTag.onclick; this.aTag.baseClick = this.aTag.onclick;
this.aTag.onclick = this.aTagOnClick.bindAsEventListener(this.aTag);
if(this.options.onParentChanged) this.onParentChanged = this.options.onParentChanged; if(this.options.onParentChanged) this.onParentChanged = this.options.onParentChanged;
if(this.options.onOrderChanged) this.onOrderChanged = this.options.onOrderChanged; if(this.options.onOrderChanged) this.onOrderChanged = this.options.onOrderChanged;
}, },
aTagOnClick: function(event) {
// This will be bound to the <a> tag, not the <li>.
if(this.treeNode.wasDragged) {
Event.stop(event);
return false;
} else {
this.treeNode.anchorWasClicked = true;
this.treeNode.wasDragged = false;
return this.baseClick(event);
}
},
/** /**
* Remove all the draggy stuff * Remove all the draggy stuff
*/ */