tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

BUGFIX Fixed potential PHP notices if headers array not set for Bcc and Cc

Browse Source 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73651 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
Sean Harvey 2009-03-25 21:43:01 +00:00
parent 0085a1ad9d
commit bd9778067c
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
email/Email.php
View File

@ -399,18 +399,24 @@ class Email extends ViewableData {
if($this->bcc) $subject .= ", bcc to $this->bcc"; if($this->bcc) $subject .= ", bcc to $this->bcc";
$subject .= ']'; $subject .= ']';
} else { } else {
if($this->cc) $headers["Cc"] = $this->cc; if($this->cc) $headers['Cc'] = $this->cc;
if($this->bcc) $headers["Bcc"] = $this->bcc; if($this->bcc) $headers['Bcc'] = $this->bcc;
} }
if(self::$cc_all_emails_to) { if(self::$cc_all_emails_to) {
if(trim($headers['Cc'])) $headers['Cc'] .= ', '; if(!empty($headers['Cc']) && trim($headers['Cc'])) {
$headers['Cc'] .= self::$cc_all_emails_to; $headers['Cc'] .= ', ' . self::$cc_all_emails_to;
} else {
$headers['Cc'] = self::$cc_all_emails_to;
}
} }
if(self::$bcc_all_emails_to) { if(self::$bcc_all_emails_to) {
if(trim($headers['Bcc'])) $headers['Bcc'] .= ', '; if(!empty($headers['Bcc']) && trim($headers['Bcc'])) {
$headers['Bcc'] .= self::$bcc_all_emails_to; $headers['Bcc'] .= ', ' . self::$bcc_all_emails_to;
} else {
$headers['Bcc'] = self::$bcc_all_emails_to;
}
} }
Requirements::restore(); Requirements::restore();
@ -456,8 +462,8 @@ class Email extends ViewableData {
unset($headers['Cc']); unset($headers['Cc']);
unset($headers['Bcc']); unset($headers['Bcc']);
} else { } else {
if($this->cc) $headers["Cc"] = $this->cc; if($this->cc) $headers['Cc'] = $this->cc;
if($this->bcc) $headers["Bcc"] = $this->bcc; if($this->bcc) $headers['Bcc'] = $this->bcc;
} }
if(self::$cc_all_emails_to) { if(self::$cc_all_emails_to) {