tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

FIX Make sure you can only remove items from a DataList that are actually in it

Browse Source
This commit is contained in:
Hamish Friedlander 2012-12-13 10:18:21 +13:00
parent 9979b11b59
commit bd59f842f0
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
model/DataList.php
View File

@ -978,9 +978,8 @@ class DataList extends ViewableData implements SS_List, SS_Filterable, SS_Sortab
*/ */
public function remove($item) { public function remove($item) {
// By default, we remove an item from a DataList by deleting it. // By default, we remove an item from a DataList by deleting it.
if($item instanceof $this->dataClass) $item->delete(); $this->removeByID($item->ID);
}
}
/** /**
* Remove an item from this DataList by ID * Remove an item from this DataList by ID