tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #563 from silverstripe-rebelalliance/trac/7427-add-responses

Browse Source 
BUGFIX: Add batch handler status messages (fixes #7427)
This commit is contained in:
Sam Minnée 2012-06-21 19:29:41 -07:00
commit bafda93957
1 changed files with 33 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
admin/code/CMSBatchAction.php
View File

@ -27,7 +27,38 @@ abstract class CMSBatchAction extends Object {
* Return a set of status-updated JavaScript to return to the CMS. * Return a set of status-updated JavaScript to return to the CMS.
*/ */
abstract function run(SS_List $objs); abstract function run(SS_List $objs);
/**
* Helper method for responding to a back action request
* @param $successMessage string - The message to return as a notification.
* Can have up to two %d's in it. The first will be replaced by the number of successful
* changes, the second by the number of failures
* @param $status array - A status array like batchactions builds. Should be
* key => value pairs, the key can be any string: "error" indicates errors, anything
* else indicates a type of success. The value is an array. We don't care what's in it,
* we just use count($value) to find the number of items that succeeded or failed
*/
public function response($successMessage, $status) {
$count = 0;
$errors = 0;
foreach($status as $k => $v) {
if ($k == 'errors') $errors = count($v);
else $count += count($v);
}
$response = Controller::curr()->getResponse();
if($response) {
$response->setStatusCode(
200,
sprintf($successMessage, $count, $errors)
);
}
return Convert::raw2json($status);
}
/** /**
* Helper method for processing batch actions. * Helper method for processing batch actions.
* Returns a set of status-updating JavaScript to return to the CMS. * Returns a set of status-updating JavaScript to return to the CMS.
@ -67,15 +98,7 @@ abstract class CMSBatchAction extends Object {
unset($obj); unset($obj);
} }
$response = Controller::curr()->getResponse(); return $this->response($successMessage, $status);
if($response) {
$response->setStatusCode(
200,
sprintf($successMessage, $objs->Count(), count($status['error']))
);
}
return Convert::raw2json($status);
} }