tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Remove optional Symfony 3.x dependencies

Browse Source 
They cause issues with installing silverstripe/behat-extension after the fact,
since it requires 2.x - and would need the existing project to downgrade the dep.
While this should be composer's default behaviour (https://github.com/composer/composer/issues/6121), from a SilverStripe perspective we should have consistent dependencies regardless of the execution path in your require calls - anything else will lead to fragile test vs. prod errors.

We can require Symfony 3.x once we've upgraded to Behat 3.x.
This commit is contained in:
Ingo Schommer 2017-02-01 18:09:25 +13:00
parent 8c6547f878
commit b95c1dec45
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
composer.json
View File

@ -23,8 +23,8 @@
"symfony/yaml": "~2.7", "symfony/yaml": "~2.7",
"embed/embed": "^2.6", "embed/embed": "^2.6",
"swiftmailer/swiftmailer": "~5.4", "swiftmailer/swiftmailer": "~5.4",
"symfony/config": "^2.8|^3", "symfony/config": "^2.8",
"symfony/translation": "^2.8|^3", "symfony/translation": "^2.8",
"vlucas/phpdotenv": "^2.4" "vlucas/phpdotenv": "^2.4"
}, },
"require-dev": { "require-dev": {