From b5d4234dfde3de2f96045050a244c122079e6d43 Mon Sep 17 00:00:00 2001 From: Sean Harvey Date: Tue, 20 Mar 2012 15:47:22 +1300 Subject: [PATCH] MINOR Correct DropdownField class documentation to include a proper example using DataList and non-deprecated way of setting the empty value and string --- forms/DropdownField.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/forms/DropdownField.php b/forms/DropdownField.php index 936b9a41c..13b755d66 100644 --- a/forms/DropdownField.php +++ b/forms/DropdownField.php @@ -13,11 +13,10 @@ * * public function getCMSFields() { * $fields = parent::getCMSFields(); - * $galleries = DataObject::get('Gallery'); - * if ($galleries) { - * $galleries = $galleries->toDropdownMap('ID', 'Title', '(Select one)', true); - * } - * $fields->addFieldToTab('Root.Content', new DropdownField('GalleryID', 'Gallery', $galleries), 'Content'); + * $field = new DropdownField('GalleryID', 'Gallery', DataList::create('Gallery')->map('ID', 'Title')); + * $field->setHasEmptyDefault(true); + * $field->setEmptyString('(Select one)'); + * $fields->addFieldToTab('Root.Content', $field, 'Content'); * * * As you see, you need to put "GalleryID", rather than "Gallery" here.