From b515a2f2d7435c32a7d721c10c08e4541be6b865 Mon Sep 17 00:00:00 2001
From: Ingo Schommer <ingo@silverstripe.com>
Date: Wed, 4 Feb 2009 01:57:15 +0000
Subject: [PATCH] BUGFIX Removed unused ComplexTableField->unpagedSourceItems -
 was already commented out in r70956, and doesn't seem to be used across
 parent- or subclasses. Added ticket #3484 to re-enable popup pagination,
 which was broken and disabled due to the deprecation of $unpagedSourceItems
 (see r53830)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71348 467b73ca-7a2a-4603-9d3b-597d59a354a9
---
 forms/ComplexTableField.php | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/forms/ComplexTableField.php b/forms/ComplexTableField.php
index f3e8cff5c..26e17396d 100755
--- a/forms/ComplexTableField.php
+++ b/forms/ComplexTableField.php
@@ -40,7 +40,7 @@ class ComplexTableField extends TableListField {
     
 	protected $detailFormFields;
 	
-	protected $viewAction, $sourceJoin, $sourceItems, $unpagedSourceItems;
+	protected $viewAction, $sourceJoin, $sourceItems;
 
 	/**
 	 * @var Controller
@@ -755,9 +755,7 @@ class ComplexTableField_ItemRequest extends RequestHandler {
 		if(!isset($_REQUEST['ctf']['start']) || !is_numeric($_REQUEST['ctf']['start']) || $_REQUEST['ctf']['start'] == 0) {
 			return null;
 		}
-		
-		// We never use $item afterwards in the function, where we have it here? disable it!
-		//$item = $this->unpagedSourceItems->First();
+
 		$start = 0;
 		return Controller::join_links($this->Link(), "$this->methodName?ctf[start]={$start}");
 	}
@@ -767,8 +765,6 @@ class ComplexTableField_ItemRequest extends RequestHandler {
 			return null;
 		}
 		
-		// We never use $item afterwards in the function, where we have it here? disable it!
-		// $item = $this->unpagedSourceItems->Last();
 		$start = $this->totalCount - 1;
 		return Controller::join_links($this->Link(), "$this->methodName?ctf[start]={$start}");
 	}
@@ -778,9 +774,6 @@ class ComplexTableField_ItemRequest extends RequestHandler {
 			return null;
 		}
 
-		// We never use $item afterwards in the function, where we have it here? disable it!
-		//$item = $this->unpagedSourceItems->getIterator()->getOffset($_REQUEST['ctf']['start'] + 1);
-
 		$start = $_REQUEST['ctf']['start'] + 1;
 		return Controller::join_links($this->Link(), "$this->methodName?ctf[start]={$start}");
 	}
@@ -790,9 +783,6 @@ class ComplexTableField_ItemRequest extends RequestHandler {
 			return null;
 		}
 
-		// We never use $item afterwards in the function, where we have it here? disable it!
-		//$item = $this->unpagedSourceItems->getIterator()->getOffset($_REQUEST['ctf']['start'] - 1);
-
 		$start = $_REQUEST['ctf']['start'] - 1;
 		return Controller::join_links($this->Link(), "$this->methodName?ctf[start]={$start}");
 	}
@@ -817,7 +807,6 @@ class ComplexTableField_ItemRequest extends RequestHandler {
         }
 		for($i = $offset;$i <= $offset + $this->pageSize && $i <= $this->totalCount;$i++) {
             $start = $i - 1;
-			$item = $this->unpagedSourceItems->getIterator()->getOffset($i-1);
 			$links['link'] = Controller::join_links($this->Link() . "$this->methodName?ctf[start]={$start}");
             $links['number'] = $i;
             $links['active'] = $i == $currentItem ? false : true;