From b3bb0a721aeb63432b14427dfea1ac9f714a1e89 Mon Sep 17 00:00:00 2001
From: Sean Harvey <sean@silverstripe.com>
Date: Tue, 21 Dec 2010 04:46:43 +0000
Subject: [PATCH] MINOR Make test database name all lowercase in case some
 databases like PostgreSQL have issues trying to detect temp database in use

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115251 467b73ca-7a2a-4603-9d3b-597d59a354a9
---
 dev/SapphireTest.php | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/dev/SapphireTest.php b/dev/SapphireTest.php
index 974d5d298..bce18d08d 100755
--- a/dev/SapphireTest.php
+++ b/dev/SapphireTest.php
@@ -145,11 +145,11 @@ class SapphireTest extends PHPUnit_Framework_TestCase {
 
 		$className = get_class($this);
 		$fixtureFile = eval("return {$className}::\$fixture_file;");
-		$prefix = defined('SS_DATABASE_PREFIX') ? SS_DATABASE_PREFIX : 'SS_';
+		$prefix = defined('SS_DATABASE_PREFIX') ? SS_DATABASE_PREFIX : 'ss_';
 
 		// Set up fixture
 		if($fixtureFile || $this->usesDatabase || !self::using_temp_db()) {
-			if(substr(DB::getConn()->currentDatabase(), 0, strlen($prefix) + 5) != sprintf('%stmpdb', $prefix)) {
+			if(substr(DB::getConn()->currentDatabase(), 0, strlen($prefix) + 5) != strtolower(sprintf('%stmpdb', $prefix))) {
 				//echo "Re-creating temp database... ";
 				self::create_temp_db();
 				//echo "done.\n";
@@ -609,13 +609,10 @@ class SapphireTest extends PHPUnit_Framework_TestCase {
 	 */
 	static function using_temp_db() {
 		$dbConn = DB::getConn();
-		$prefix = defined('SS_DATABASE_PREFIX') ? SS_DATABASE_PREFIX : 'SS_';
-		return $dbConn && (substr($dbConn->currentDatabase(), 0, strlen($prefix) + 5) == sprintf('%stmpdb', $prefix));
+		$prefix = defined('SS_DATABASE_PREFIX') ? SS_DATABASE_PREFIX : 'ss_';
+		return $dbConn && (substr($dbConn->currentDatabase(), 0, strlen($prefix) + 5) == strtolower(sprintf('%stmpdb', $prefix)));
 	}
 	
-	/**
-	 * @todo Make this db agnostic
-	 */
 	static function kill_temp_db() {
 		// Delete our temporary database
 		if(self::using_temp_db()) {
@@ -652,19 +649,16 @@ class SapphireTest extends PHPUnit_Framework_TestCase {
 		}
 	}
 	
-	/**
-	 * @todo Make this db agnostic
-	 */
 	static function create_temp_db() {
 		// Disable PHPUnit error handling
 		restore_error_handler();
 		
 		// Create a temporary database
 		$dbConn = DB::getConn();
-		$prefix = defined('SS_DATABASE_PREFIX') ? SS_DATABASE_PREFIX : 'SS_';
-		$dbname = sprintf('%stmpdb', $prefix) . rand(1000000,9999999);
+		$prefix = defined('SS_DATABASE_PREFIX') ? SS_DATABASE_PREFIX : 'ss_';
+		$dbname = strtolower(sprintf('%stmpdb', $prefix)) . rand(1000000,9999999);
 		while(!$dbname || $dbConn->databaseExists($dbname)) {
-			$dbname = sprintf('%stmpdb', $prefix) . rand(1000000,9999999);
+			$dbname = strtolower(sprintf('%stmpdb', $prefix)) . rand(1000000,9999999);
 		}
 
 		$dbConn->selectDatabase($dbname);
@@ -680,7 +674,7 @@ class SapphireTest extends PHPUnit_Framework_TestCase {
 	}
 	
 	static function delete_all_temp_dbs() {
-		$prefix = defined('SS_DATABASE_PREFIX') ? SS_DATABASE_PREFIX : 'SS_';
+		$prefix = defined('SS_DATABASE_PREFIX') ? SS_DATABASE_PREFIX : 'ss_';
 		foreach(DB::getConn()->allDatabaseNames() as $dbName) {
 			if(preg_match(sprintf('/^%stmpdb[0-9]+$/', $prefix), $dbName)) {
 				DB::getConn()->dropDatabaseByName($dbName);