From b29b49e7d763ebbc7842694be84873c36650230f Mon Sep 17 00:00:00 2001 From: Giulio Bonanome Date: Wed, 11 Dec 2013 16:17:30 +0100 Subject: [PATCH] Fix empty $messageBlock on CheckboxFields From 2.4.13 the Message attribute is set to Text, so every checkbox now show an empty $messageBlock, See https://github.com/silverstripe/silverstripe-framework/issues/2489 or http://www.silverstripe.org/general-questions/show/25254 --- forms/CheckboxField.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/forms/CheckboxField.php b/forms/CheckboxField.php index 498e461ff..68e3537f3 100755 --- a/forms/CheckboxField.php +++ b/forms/CheckboxField.php @@ -47,7 +47,7 @@ class CheckboxField extends FormField { } else { extract($this->getXMLValues(array( 'Name', 'Field', 'Title', 'Message', 'MessageType' )), EXTR_SKIP); - $messageBlock = isset($Message) ? "$Message" : ''; + $messageBlock = empty($Message) ? '' : "$Message"; $Type = $this->XML_val('Type'); $extraClass = $this->XML_val('extraClass'); return <<createTag('input', $attributes); } } -?> \ No newline at end of file +?>