tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

BUGFIX Fixed ID associations in TableListFieldTest (was assuming numerically ascending IDs, which isnt necessarily true in Postgres)

Browse Source 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@87913 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
Ingo Schommer 2009-10-01 21:51:58 +00:00
parent d9b1b66c2b
commit afcf846b90
1 changed files with 32 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
tests/forms/TableListFieldTest.php
View File

@ -25,6 +25,12 @@ class TableListFieldTest extends SapphireTest {
} }
function testUnpaginatedSourceItemGeneration() { function testUnpaginatedSourceItemGeneration() {
$item1 = $this->objFromFixture('TableListFieldTest_Obj', 'one');
$item2 = $this->objFromFixture('TableListFieldTest_Obj', 'two');
$item3 = $this->objFromFixture('TableListFieldTest_Obj', 'three');
$item4 = $this->objFromFixture('TableListFieldTest_Obj', 'four');
$item5 = $this->objFromFixture('TableListFieldTest_Obj', 'five');
/* In this simple case, the source items should just list all the data objects specified */ /* In this simple case, the source items should just list all the data objects specified */
$table = new TableListField("Tester", "TableListFieldTest_Obj", array( $table = new TableListField("Tester", "TableListFieldTest_Obj", array(
"A" => "Col A", "A" => "Col A",
@ -41,13 +47,23 @@ class TableListFieldTest extends SapphireTest {
$items = $table->sourceItems(); $items = $table->sourceItems();
$this->assertNotNull($items); $this->assertNotNull($items);
//Disabled due to Postgres not liking the ID numbers to be dictated. $itemMap = $items->toDropdownMap("ID", "A") ;
//The items are returned in the correct order, but with different keys. $this->assertEquals(array(
//$itemMap = $items->toDropdownMap("ID", "A") ; $item1->ID => "a1",
//$this->assertEquals(array(1 => "a1", 2 => "a2", 3 => "a3", 4 => "a4", 5 => "a5"), $itemMap); $item2->ID => "a2",
$item3->ID => "a3",
$item4->ID => "a4",
$item5->ID => "a5"
), $itemMap);
} }
function testFirstPageOfPaginatedSourceItemGeneration() { function testFirstPageOfPaginatedSourceItemGeneration() {
$item1 = $this->objFromFixture('TableListFieldTest_Obj', 'one');
$item2 = $this->objFromFixture('TableListFieldTest_Obj', 'two');
$item3 = $this->objFromFixture('TableListFieldTest_Obj', 'three');
$item4 = $this->objFromFixture('TableListFieldTest_Obj', 'four');
$item5 = $this->objFromFixture('TableListFieldTest_Obj', 'five');
/* With pagination enabled, only the first page of items should be shown */ /* With pagination enabled, only the first page of items should be shown */
$table = new TableListField("Tester", "TableListFieldTest_Obj", array( $table = new TableListField("Tester", "TableListFieldTest_Obj", array(
"A" => "Col A", "A" => "Col A",
@ -67,13 +83,20 @@ class TableListFieldTest extends SapphireTest {
$items = $table->sourceItems(); $items = $table->sourceItems();
$this->assertNotNull($items); $this->assertNotNull($items);
//Disabled due to Postgres not liking the ID numbers to be dictated.
//The items are returned in the correct order, but with different keys.
$itemMap = $items->toDropdownMap("ID", "A") ; $itemMap = $items->toDropdownMap("ID", "A") ;
$this->assertEquals(array(1 => "a1", 2 => "a2"), $itemMap); $this->assertEquals(array(
$item1->ID => "a1",
$item2->ID => "a2"
), $itemMap);
} }
function testSecondPageOfPaginatedSourceItemGeneration() { function testSecondPageOfPaginatedSourceItemGeneration() {
$item1 = $this->objFromFixture('TableListFieldTest_Obj', 'one');
$item2 = $this->objFromFixture('TableListFieldTest_Obj', 'two');
$item3 = $this->objFromFixture('TableListFieldTest_Obj', 'three');
$item4 = $this->objFromFixture('TableListFieldTest_Obj', 'four');
$item5 = $this->objFromFixture('TableListFieldTest_Obj', 'five');
/* With pagination enabled, only the first page of items should be shown */ /* With pagination enabled, only the first page of items should be shown */
$table = new TableListField("Tester", "TableListFieldTest_Obj", array( $table = new TableListField("Tester", "TableListFieldTest_Obj", array(
"A" => "Col A", "A" => "Col A",
@ -94,10 +117,8 @@ class TableListFieldTest extends SapphireTest {
$items = $table->sourceItems(); $items = $table->sourceItems();
$this->assertNotNull($items); $this->assertNotNull($items);
//Disabled due to Postgres not liking the ID numbers to be dictated. $itemMap = $items->toDropdownMap("ID", "A") ;
//The items are returned in the correct order, but with different keys. $this->assertEquals(array($item3->ID => "a3", $item4->ID => "a4"), $itemMap);
//$itemMap = $items->toDropdownMap("ID", "A") ;
//$this->assertEquals(array(3 => "a3", 4 => "a4"), $itemMap);
} }
/** /**