tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

Fix $class variable from being clobbered

Browse Source 
The $class variable gets overwritten in the function.

This causes error messages to be less helpful. For example if you setup a has_many but forget the has_one on the other side the error will look something like

`[Emergency] Uncaught Exception: No has_one found on class 'SomeObject', the has_many relation from 'SilverStripe\View\ViewableData' to 'SomeObject' requires a has_one on 'SomeObject'`

fixing this gives a more useful error, like

`[Emergency] Uncaught Exception: No has_one found on class 'SomeObject', the has_many relation from 'Page' to 'SomeObject' requires a has_one on 'SomeObject'`
This commit is contained in:
Nick 2017-05-29 20:31:09 +12:00 committed by GitHub
parent 77444ca28d
commit acb74a8577
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ORM/DataObjectSchema.php
View File

@ -922,9 +922,9 @@ class DataObjectSchema
if (empty($remoteField)) { if (empty($remoteField)) {
// look for remote has_one joins on this class or any parent classes // look for remote has_one joins on this class or any parent classes
$remoteRelationsMap = array_flip($remoteRelations); $remoteRelationsMap = array_flip($remoteRelations);
foreach (array_reverse(ClassInfo::ancestry($class)) as $class) { foreach (array_reverse(ClassInfo::ancestry($class)) as $ancestryClass) {
if (array_key_exists($class, $remoteRelationsMap)) { if (array_key_exists($ancestryClass, $remoteRelationsMap)) {
$remoteField = $remoteRelationsMap[$class]; $remoteField = $remoteRelationsMap[$ancestryClass];
break; break;
} }
} }