tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #7596 from andrewandante/pulls/sanitise_select_tag_3

Browse Source 
sanitise select tag in DropdownField Docblock
This commit is contained in:
Damian Mooyman 2017-11-15 14:17:30 +13:00 committed by GitHub
commit abe0e96192
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
forms/DropdownField.php
View File

@ -1,6 +1,6 @@
<?php <?php
/** /**
* Dropdown field, created from a <select> tag. * Dropdown field, created from a select tag.
* *
* <b>Setting a $has_one relation</b> * <b>Setting a $has_one relation</b>
* *

6
forms/FormField.php
View File

@ -513,7 +513,7 @@ class FormField extends RequestHandler {
} }
/** /**
* Set an HTML attribute on the field element, mostly an <input> tag. * Set an HTML attribute on the field element, mostly an input tag.
* *
* Some attributes are best set through more specialized methods, to avoid interfering with * Some attributes are best set through more specialized methods, to avoid interfering with
* built-in behaviour: * built-in behaviour:
@ -1103,7 +1103,7 @@ class FormField extends RequestHandler {
* *
* The field type is the class name with the word Field dropped off the end, all lowercase. * The field type is the class name with the word Field dropped off the end, all lowercase.
* *
* It's handy for assigning HTML classes. Doesn't signify the <input type> attribute. * It's handy for assigning HTML classes. Doesn't signify the input type attribute.
* *
* @see {link getAttributes()}. * @see {link getAttributes()}.
* *
@ -1145,7 +1145,7 @@ class FormField extends RequestHandler {
/** /**
* Describe this field, provide help text for it. * Describe this field, provide help text for it.
* *
* By default, renders as a <span class="description"> underneath the form field. * By default, renders as a span class="description" underneath the form field.
* *
* @param string $description * @param string $description
* *

10
forms/GroupedDropdownField.php
View File

@ -1,13 +1,13 @@
<?php <?php
/** /**
* Grouped dropdown, using <optgroup> tags. * Grouped dropdown, using optgroup tags.
* *
* $source parameter (from DropdownField) must be a two dimensional array. * $source parameter (from DropdownField) must be a two dimensional array.
* The first level of the array is used for the <optgroup>, and the second * The first level of the array is used for the optgroup, and the second
* level are the <options> for each group. * level are the options for each group.
* *
* Returns a <select> tag containing all the appropriate <option> tags, with * Returns a select tag containing all the appropriate option tags, with
* <optgroup> tags around the <option> tags as required. * optgroup tags around the option tags as required.
* *
* <b>Usage</b> * <b>Usage</b>
* *

6
forms/ListboxField.php
View File

@ -1,6 +1,6 @@
<?php <?php
/** /**
* Multi-line listbox field, created from a <select> tag. * Multi-line listbox field, created from a select tag.
* *
* <b>Usage</b> * <b>Usage</b>
* *
@ -17,7 +17,7 @@
* ) * )
* </code> * </code>
* *
* @see DropdownField for a simple <select> field with a single element. * @see DropdownField for a simple select field with a single element.
* @see CheckboxSetField for multiple selections through checkboxes. * @see CheckboxSetField for multiple selections through checkboxes.
* @see OptionsetField for single selections via radiobuttons. * @see OptionsetField for single selections via radiobuttons.
* @see TreeDropdownField for a rich and customizeable UI that can visualize a tree of selectable elements * @see TreeDropdownField for a rich and customizeable UI that can visualize a tree of selectable elements
@ -69,7 +69,7 @@ class ListboxField extends DropdownField {
} }
/** /**
* Returns a <select> tag containing all the appropriate <option> tags * Returns a select tag containing all the appropriate option tags
*/ */
public function Field($properties = array()) { public function Field($properties = array()) {
if($this->multiple) $this->name .= '[]'; if($this->multiple) $this->name .= '[]';