tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #10829 from creative-commoners/pulls/4.13/fix-last-page

Browse Source 
FIX LastPage method returns true if TotalPages equals 0
This commit is contained in:
Guy Sartorelli 2023-06-22 11:16:57 +12:00 committed by GitHub
commit ab4802caaf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ORM/PaginatedList.php
View File

@ -416,7 +416,7 @@ class PaginatedList extends ListDecorator
*/ */
public function LastPage() public function LastPage()
{ {
return $this->CurrentPage() == $this->TotalPages(); return $this->CurrentPage() >= $this->TotalPages();
} }
/** /**

11
tests/php/ORM/PaginatedListTest.php
View File

@ -303,9 +303,20 @@ class PaginatedListTest extends SapphireTest
$list = new PaginatedList(new ArrayList()); $list = new PaginatedList(new ArrayList());
$list->setTotalItems(50); $list->setTotalItems(50);
$this->assertFalse($list->LastPage());
$list->setCurrentPage(4);
$this->assertFalse($list->LastPage()); $this->assertFalse($list->LastPage());
$list->setCurrentPage(5); $list->setCurrentPage(5);
$this->assertTrue($list->LastPage()); $this->assertTrue($list->LastPage());
$list->setCurrentPage(6);
$this->assertTrue($list->LastPage());
$emptyList = new PaginatedList(new ArrayList());
$emptyList->setTotalItems(0);
$this->assertTrue($emptyList->LastPage());
$emptyList->setCurrentPage(1);
$this->assertTrue($emptyList->LastPage());
} }
public function testNotLastPage() public function testNotLastPage()