Merge pull request #5665 from tractorcow/pulls/3.3/fix-button-clicked

BUG Fix buttonClicked() error
This commit is contained in:
Daniel Hensby 2016-07-15 00:30:25 +01:00 committed by GitHub
commit a64a066bbf
2 changed files with 18 additions and 6 deletions

View File

@ -1635,11 +1635,17 @@ class Form extends RequestHandler {
* @return FormAction
*/
public function buttonClicked() {
foreach($this->actions->dataFields() as $action) {
if($action->hasMethod('actionname') && $this->buttonClickedFunc == $action->actionName()) {
$actions = $this->actions->dataFields();
if(!$actions) {
return null;
}
foreach($actions as $action) {
if($action instanceof FormAction && $this->buttonClickedFunc == $action->actionName()) {
return $action;
}
}
return null;
}
/**

View File

@ -537,6 +537,12 @@ class FormTest extends FunctionalTest {
$this->assertEquals('bar', $attrs['foo']);
}
public function testButtonClicked() {
$form = $this->getStubForm();
$action = $form->buttonClicked();
$this->assertNull($action);
}
public function testAttributesHTML() {
$form = $this->getStubForm();