mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-22 12:05:37 +00:00
API CHANGE Decimal now allows setting a default value properly
MINOR Unit tests for Decimal field type default value through new test class DecimalTest (from r98056) git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102571 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
parent
529ed1dd1d
commit
a5dde231b6
@ -582,7 +582,12 @@ class MySQLDatabase extends SS_Database {
|
||||
$precision = $values['precision'];
|
||||
}
|
||||
|
||||
return 'decimal(' . $precision . ') not null';
|
||||
$defaultValue = '';
|
||||
if(isset($values['default']) && is_numeric($values['default'])) {
|
||||
$defaultValue = ' default ' . $values['default'];
|
||||
}
|
||||
|
||||
return 'decimal(' . $precision . ') not null' . $defaultValue;
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -5,14 +5,15 @@
|
||||
* @subpackage model
|
||||
*/
|
||||
class Decimal extends DBField {
|
||||
protected $wholeSize, $decimalSize;
|
||||
protected $wholeSize, $decimalSize, $defaultValue;
|
||||
|
||||
/**
|
||||
* Create a new Decimal field.
|
||||
*/
|
||||
function __construct($name, $wholeSize = 9, $decimalSize = 2) {
|
||||
function __construct($name, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0) {
|
||||
$this->wholeSize = isset($wholeSize) ? $wholeSize : 9;
|
||||
$this->decimalSize = isset($decimalSize) ? $decimalSize : 2;
|
||||
$this->defaultValue = $defaultValue;
|
||||
parent::__construct($name);
|
||||
}
|
||||
|
||||
@ -25,7 +26,7 @@ class Decimal extends DBField {
|
||||
}
|
||||
|
||||
function requireField() {
|
||||
$parts=Array('datatype'=>'decimal', 'precision'=>"$this->wholeSize,$this->decimalSize", 'arrayValue'=>$this->arrayValue);
|
||||
$parts=Array('datatype'=>'decimal', 'precision'=>"$this->wholeSize,$this->decimalSize", 'default'=>$this->defaultValue, 'arrayValue'=>$this->arrayValue);
|
||||
$values=Array('type'=>'decimal', 'parts'=>$parts);
|
||||
DB::requireField($this->tableName, $this->name, $values);
|
||||
}
|
||||
|
Loading…
x
Reference in New Issue
Block a user