From bf3f159800ec37a7ac5daf892f90fd3f7645c491 Mon Sep 17 00:00:00 2001 From: Peter Thaleikis Date: Wed, 22 Jul 2015 22:35:58 +1200 Subject: [PATCH 1/2] harden addFilter method --- model/DataList.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/model/DataList.php b/model/DataList.php index 5699730e8..9f1a83114 100644 --- a/model/DataList.php +++ b/model/DataList.php @@ -372,8 +372,10 @@ class DataList extends ViewableData implements SS_List, SS_Filterable, SS_Sortab /** * Return a new instance of the list with an added filter + * + * @param array $filterArray */ - public function addFilter($filterArray) { + public function addFilter(array $filterArray) { $list = $this; foreach($filterArray as $field => $value) { From e26ad64b75c14bca344e8c022f41de6e572547ea Mon Sep 17 00:00:00 2001 From: Peter Thaleikis Date: Thu, 23 Jul 2015 22:28:59 +1200 Subject: [PATCH 2/2] remove the API change --- model/DataList.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/model/DataList.php b/model/DataList.php index 9f1a83114..813a8453c 100644 --- a/model/DataList.php +++ b/model/DataList.php @@ -373,9 +373,9 @@ class DataList extends ViewableData implements SS_List, SS_Filterable, SS_Sortab /** * Return a new instance of the list with an added filter * - * @param array $filterArray + * @param array $filterArray */ - public function addFilter(array $filterArray) { + public function addFilter($filterArray) { $list = $this; foreach($filterArray as $field => $value) {