tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-02 14:18:46 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #3508 from tractorcow/pulls/3.1/fix-unsavedrelationlist

Browse Source 
FIX use @param $colName in column call
This commit is contained in:
Sean Harvey 2014-09-26 09:53:31 +12:00
commit a20813da9e
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
model/UnsavedRelationList.php
View File

@ -261,7 +261,7 @@ class UnsavedRelationList extends ArrayList {
*/
public function column($colName = 'ID') {
$list = new ArrayList($this->toArray());
return $list->column('ID');
return $list->column($colName);
}
/**

23
tests/model/UnsavedRelationListTest.php
View File

@ -183,6 +183,29 @@ class UnsavedRelationListTest extends SapphireTest {
$child3->ID => $child3->ID
));
}
public function testColumn() {
$object = new UnsavedRelationListTest_DataObject;
$children = $object->Children();
$children->add(new UnsavedRelationListTest_DataObject(array('Name' => 'A')));
$children->add(new UnsavedRelationListTest_DataObject(array('Name' => 'B')));
$children->add(new UnsavedRelationListTest_DataObject(array('Name' => 'C')));
$children = $object->Children();
$this->assertDOSEquals(array(
array('Name' => 'A'),
array('Name' => 'B'),
array('Name' => 'C')
), $children);
$this->assertEquals($children->column('Name'), array(
'A',
'B',
'C'
));
}
}
class UnsavedRelationListTest_DataObject extends DataObject implements TestOnly {