tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Moved <select> styles to generic _forms.scss

Browse Source 
Form element styles should be consistent throughout the CMS.
While we still have the ability to create dropdowns (<select>) which aren't based on
Entwine/HTML rather than new components like <SingleSelectField>,
we need to ensure those are rendered the same.

By default, the Entwine-based CMS sections will transform <select>
into a ChosenJS control, but you can still apply .no-chosen.
Hence there's a need for correct height both in React and Entwine sections,
not just in a React component.
This commit is contained in:
Ingo Schommer 2016-08-28 13:30:18 +12:00
parent 79b9bb6f18
commit a0d4e363c2
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
admin/client/dist/styles/bundle.css vendored
View File

File diff suppressed because one or more lines are too long

3
admin/client/src/components/SingleSelectField/SingleSelectField.scss
View File

@ -1,3 +0,0 @@
select.form-control:not([size]):not([multiple]) {
height: 2.5rem;
}

1
admin/client/src/styles/bundle.scss
View File

@ -34,7 +34,6 @@
@import "../components/PopoverField/PopoverField"; @import "../components/PopoverField/PopoverField";
@import "../components/GridField/GridField"; @import "../components/GridField/GridField";
@import "../components/HiddenField/HiddenField"; @import "../components/HiddenField/HiddenField";
@import "../components/SingleSelectField/SingleSelectField";
@import "../components/Label/Label"; @import "../components/Label/Label";
@import "../components/Preview/Preview"; @import "../components/Preview/Preview";
@import "../components/Toolbar/Toolbar"; @import "../components/Toolbar/Toolbar";

4
admin/client/src/styles/legacy/_forms.scss
View File

@ -54,6 +54,10 @@ form.nostyle {
margin-left: 0; margin-left: 0;
} }
select:not([size]):not([multiple]) {
height: 2.5rem;
}
input.text, input.text,
input.creditcard, input.creditcard,
textarea, textarea,